Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 16, 2013, 1:42 p.m.) Status -- This change has been ma

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review40117 --- This review has been submitted with commit fb72740e2c9e950b913

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39951 --- Ship it! Looks good. Remember to adjust the commit log if it s

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 13, 2013, 11:01 a.m.) Review request for KDE Frameworks.

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39942 --- staging/kcompletion/src/klineedit.cpp

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-12 Thread Chusslove Illich
> On Sept. 12, 2013, 9:06 p.m., Chusslove Illich wrote: > > > [: Aleix Pol Gonzalez :] > It's not really adding much value here, so I'd say we can drop it. I agree that none of these strings seem like they would need ki18n's specialties. (I can't comment on what the proper form of tr() is for

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-12 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39914 --- - Chusslove Illich On Sept. 12, 2013, 4:47 p.m., Aleix Pol Go

Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- Review request for KDE Frameworks. Description --- It's not really ad