----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39942 -----------------------------------------------------------
staging/kcompletion/src/klineedit.cpp <http://git.reviewboard.kde.org/r/112689/#comment29488> QObject::tr ( const char * sourceText, const char * disambiguation = 0 ) -> you need to swap the arguments around. - David Faure On Sept. 12, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112689/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2013, 2:47 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > It's not really adding much value here, so I'd say we can drop it. > > I'm not sure that tr() is as well the correct replacement for i18nc(), can > anybody confirm? > > > Diffs > ----- > > staging/kcompletion/src/CMakeLists.txt dd9d99c > staging/kcompletion/src/kcombobox.cpp 8a73a1b > staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 > staging/kcompletion/src/klineedit.cpp 76ef377 > > Diff: http://git.reviewboard.kde.org/r/112689/diff/ > > > Testing > ------- > > builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
