----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39951 -----------------------------------------------------------
Ship it! Looks good. Remember to adjust the commit log if it still contains your question about tr()/i18nc(). - David Faure On Sept. 13, 2013, 11:01 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112689/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 11:01 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > It's not really adding much value here, so I'd say we can drop it. > > I'm not sure that tr() is as well the correct replacement for i18nc(), can > anybody confirm? > > > Diffs > ----- > > staging/kcompletion/src/CMakeLists.txt dd9d99c > staging/kcompletion/src/kcombobox.cpp 8a73a1b > staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 > staging/kcompletion/src/klineedit.cpp 76ef377 > staging/knotifications/CMakeLists.txt 2e42ab3 > > Diff: http://git.reviewboard.kde.org/r/112689/diff/ > > > Testing > ------- > > builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
