Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40239 --- This review has been submitted with commit 032cb2b94a1463f53f9

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 17, 2013, 5:30 p.m.) Status -- This change has been ma

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40211 --- Ship it! Looks good to me now. - Aurélien Gâteau On Sept. 1

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40184 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 16

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 16, 2013, 11:45 p.m.) Review request for KDE Frameworks.

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
> On Sept. 11, 2013, 4:13 p.m., Aurélien Gâteau wrote: > > tier1/kwidgetsaddons/src/kselectaction.cpp, line 240 > > > > > > To avoid duplication you could reimplement > > KSelectAction::addAction(act) as insertAc

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 11, 2013, 5:06 p.m.) Review request for KDE Frameworks. D

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39840 --- A few nitpicks, but I like this version better. tier1/kwidget

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 11, 2013, 2:55 p.m.) Review request for KDE Frameworks. D

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-10 Thread David Edmundson
> On Sept. 9, 2013, 2:39 p.m., Aurélien Gâteau wrote: > > Instead of adding methods to get buttons and combo boxes from > > KSelectAction, which is an implementation detail to me, what about this: > > > > - Add KSelectAction::insertAction(QAction* before, QAction*) (because what > > KRecentFil

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-09 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39649 --- Instead of adding methods to get buttons and combo boxes from K

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39551 --- staging/kconfigwidgets/src/CMakeLists.txt

Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- Review request for KDE Frameworks. Description --- KConfigWidgets rel