> On Sept. 11, 2013, 4:13 p.m., Aurélien Gâteau wrote: > > tier1/kwidgetsaddons/src/kselectaction.cpp, line 240 > > <http://git.reviewboard.kde.org/r/112583/diff/2/?file=188967#file188967line240> > > > > To avoid duplication you could reimplement > > KSelectAction::addAction(act) as insertAction(0, act) > > > > You might also want to make KSelectAction::addAction() not virtual, so > > that there is only one way to change the class behavior when actions are > > added/inserted.
I originally thought about doing that then rejected it assuming QWidget::addAction() would be somehow faster than insertAction() and we shouldn't throw that away. Now I've looked at Qt code it shows that they just call insertAction(0, action); so it does make sense for us to do the same thing. Will change. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39840 ----------------------------------------------------------- On Sept. 11, 2013, 2:55 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112583/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2013, 2:55 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > KConfigWidgets relies on a private header in KWidgetAddons. This prevents > KConfigWidgets building on it's own > > By exposing the two of these private members in protected methods, we can > solve this problem. > > > Commit log below: > -------------- > > change target link libraries to ${lib_LIBRARIES} format > -- > > Remove inheritance on KSelectionActionPrivate in KRecentFileActions > > This is in a different framework so cannot be used when building > standalone. > > -- > Expose associated comboboxes and toolbuttons in KSelectAction > > > Diffs > ----- > > staging/kconfigwidgets/src/CMakeLists.txt > dad6bcc140cb4fe56380bd44ea007fe1f06edace > staging/kconfigwidgets/src/krecentfilesaction.h > edf77a24866018134d9c5a200c6e35213742c555 > staging/kconfigwidgets/src/krecentfilesaction.cpp > 9aa5f8bd83d064402dd6333c7cd89a388d373fe1 > staging/kconfigwidgets/src/krecentfilesaction_p.h > 8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c > tier1/kwidgetsaddons/src/kselectaction.h > 07afaa960d2be4877aeef0ff074d0fd20c7b7f40 > tier1/kwidgetsaddons/src/kselectaction.cpp > 3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e > > Diff: http://git.reviewboard.kde.org/r/112583/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
