----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39551 -----------------------------------------------------------
staging/kconfigwidgets/src/CMakeLists.txt <http://git.reviewboard.kde.org/r/112583/#comment29139> AFAIK, this is not needed. When imported, the *Config.cmake files create something that is called "imported targets" in cmake which basically means that you can use it right away. It's similar to how you can link against QtCore using Qt5::Core and you don't need a ${variable}. BTW, are you sure that many publicly linked libraries are needed? - Aleix Pol Gonzalez On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112583/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2013, 7:45 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > KConfigWidgets relies on a private header in KWidgetAddons. This prevents > KConfigWidgets building on it's own > > By exposing the two of these private members in protected methods, we can > solve this problem. > > > Commit log below: > -------------- > > change target link libraries to ${lib_LIBRARIES} format > -- > > Remove inheritance on KSelectionActionPrivate in KRecentFileActions > > This is in a different framework so cannot be used when building > standalone. > > -- > Expose associated comboboxes and toolbuttons in KSelectAction > > > Diffs > ----- > > staging/kconfigwidgets/src/CMakeLists.txt > dad6bcc140cb4fe56380bd44ea007fe1f06edace > staging/kconfigwidgets/src/krecentfilesaction.h > edf77a24866018134d9c5a200c6e35213742c555 > staging/kconfigwidgets/src/krecentfilesaction.cpp > 9aa5f8bd83d064402dd6333c7cd89a388d373fe1 > staging/kconfigwidgets/src/krecentfilesaction_p.h > 8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c > tier1/kwidgetsaddons/src/kselectaction.h > 07afaa960d2be4877aeef0ff074d0fd20c7b7f40 > tier1/kwidgetsaddons/src/kselectaction.cpp > b388df94baa042e8230f2795f35dd378117c6ab6 > > Diff: http://git.reviewboard.kde.org/r/112583/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
