Time to move Modem Manager Qt now? Last Plasma 5.2.2 is tarred and KF 5.9
is due for tagging in 2 weeks.
Jonathan
On 16 March 2015 at 15:44, Jan Grulich wrote:
> On Thursday 12 of March 2015 14:12 David Edmundson wrote:
> > Looks good to me.
> > 2 minor comments.
> >
> > All classes are names
On Thursday 12 of March 2015 14:12 David Edmundson wrote:
> Looks good to me.
> 2 minor comments.
>
> All classes are namespaced, but generictypes.h is not.
> Given these names could easily clash with something else and are publicly
> included, it might be worth putting them in the same namespace.
El Dijous, 12 de març de 2015, a les 09:56:06, Jan Grulich va escriure:
> Hi all,
>
> I would like to ask you if you could review ModemManagerQt library
> (currently as libmm-qt). I want to make it as framework before KF5 5.9.0
> gets released and make Plasma 5.3 depend on it, otherwise we would h
Looks good to me.
2 minor comments.
All classes are namespaced, but generictypes.h is not.
Given these names could easily clash with something else and are publicly
included, it might be worth putting them in the same namespace.
ModemManager::ModemMessaging::messages can be const?
David
Hi all,
I would like to ask you if you could review ModemManagerQt library (currently
as libmm-qt). I want to make it as framework before KF5 5.9.0 gets released
and make Plasma 5.3 depend on it, otherwise we would have to release it again
together with Plasma and wait three more months. The on
