On Thursday 12 of March 2015 14:12 David Edmundson wrote: > Looks good to me. > 2 minor comments. > > All classes are namespaced, but generictypes.h is not. > Given these names could easily clash with something else and are publicly > included, it might be worth putting them in the same namespace.
Done. > ModemManager::ModemMessaging::messages can be const? Yes, fixed. > > David > > On Friday 13 of March 2015 00:06 Albert Astals Cid wrote: > Kill the framework branch? Removed. > Move macros.h and mmdebug.h to _p.h? Done. > Can listBearers and findBearer be const? Yep, done. > In InterfaceType i'd say you can let the enums be there even if the > MM_CHECK_VERSION doesn't match, makes sure in case some others are added > later they always have the same "int" value Removed check. > Make BearerStruct, IpConfig and NetworkTimeZonea and the structs in > generictypes.h classes with dptr in case you ever need more fields in them? I made only BearerStruct, IpConfig and NetworkTimeZone as classes. Other structures are just pairs and won't need more fields in future. > Add const & to params of ip4ConfigChanged, ip6ConfigChanged and > networkTimeZoneChanged? Done. > Cheers, > Albert > Thanks, is there anything else? Regards, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
