Looks good to me. 2 minor comments. All classes are namespaced, but generictypes.h is not. Given these names could easily clash with something else and are publicly included, it might be worth putting them in the same namespace.
ModemManager::ModemMessaging::messages can be const? David
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
