chinmoyr abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
Cc: fvogt, dfaure, davidedmundson, michaelh, ngraham
dfaure added a comment.
OK now I see the purpose of the Helper class. Strange that it appeared in the
previous commit, but OK.
INLINE COMMENTS
> deletejobtest.cpp:119
> +QVERIFY(spy.isValid());
> +QVERIFY(spy.wait(10));
> +QCOMPARE(job->error(), KJOB_NO_ERROR);
100s is too m
chinmoyr added a dependent revision: D6383: Add KAuth support to KIO's symlink
operation.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
Cc: davidedmundson
chinmoyr added a comment.
> If there was a malicous agent hiding in a dolphin plugin, it would just be
making a direct call to the helper and skip all that.
Till now I was not aware of what a dolphin plugin can or cannot do. I assumed
there would be some kind of restriction. I was wrong
davidedmundson added a comment.
> There are additional prompts as well.
Those prompts are in the client code.
If there was a malicous agent hiding in a dolphin plugin, it would just be
making a direct call to the helper and skip all that.
REPOSITORY
R241 KIO
REVISION DETAIL
https:
chinmoyr added inline comments.
INLINE COMMENTS
> davidedmundson wrote in file.actions:5
> We don't want session persistence
>
> It would mean if you prompt the user to delete a file, any rogue plugin in
> Dolphin can now remove any file without prompts.
> It would mean if you prompt the user
chinmoyr updated this revision to Diff 15732.
chinmoyr added a comment.
minor fixes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15625&id=15732
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
autotests/deletejobtest.cpp
autote
chinmoyr updated this revision to Diff 15625.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.
Added unit tests and addressed minor issues.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15517&id=15625
REVISION DETAIL
https://phab
elvisangelaccio added inline comments.
INLINE COMMENTS
> davidedmundson wrote in file.actions:5
> We don't want session persistence
>
> It would mean if you prompt the user to delete a file, any rogue plugin in
> Dolphin can now remove any file without prompts.
> We don't want session persiste
davidedmundson added inline comments.
INLINE COMMENTS
> file.actions:5
> +Policy=auth_admin
> +Persistence=session
We don't want session persistence
It would mean if you prompt the user to delete a file, any rogue plugin in
Dolphin can now remove any file without prompts.
> helper.cpp:46
> +
chinmoyr updated this revision to Diff 15517.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15516&id=15517
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
src/ioslaves/fi
chinmoyr updated this revision to Diff 15516.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15388&id=15516
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
src/ioslaves/fi
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file.actions:3
> +Name=Remove items as a privileged user.
> +Description=Remove items as a privileged user.
> +Policy=auth_admin
Let's impro
chinmoyr edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
chinmoyr created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch makes it possible to delete root owned files and folders.
To avoid any accidental deletion a warning is shown informing the user about
the write-protection. The warnings can either
15 matches
Mail list logo
