davidedmundson added inline comments.
INLINE COMMENTS
> file.actions:5
> +Policy=auth_admin
> +Persistence=session
We don't want session persistence
It would mean if you prompt the user to delete a file, any rogue plugin in
Dolphin can now remove any file without prompts.
> helper.cpp:46
> + if (errno == EACCES || errno == EPERM) {
> + QVariantMap errorData;
> + errorData.insert(QStringLiteral("errormessage"), i18n("Access
> Denied!"));
Rather than replying with Success when you fail, with your own structure use
setError (not errorCode) and setErrorDescription
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
Cc: davidedmundson
