dfaure added a comment.
OK now I see the purpose of the Helper class. Strange that it appeared in the
previous commit, but OK.
INLINE COMMENTS
> deletejobtest.cpp:119
> + QVERIFY(spy.isValid());
> + QVERIFY(spy.wait(100000));
> + QCOMPARE(job->error(), KJOB_NO_ERROR);
100s is too much, please remove a zero.
> deletejobtest.cpp:122
> +
> + QStringList testData = job->queryMetaData("TestData").split(',');
> + QCOMPARE(testData.first(), QStringLiteral("org.kde.kio.file.del"));
Make it const so that first() doesn't detach.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
Cc: dfaure, davidedmundson
