D20655: Use generated DBus interface

bruns added a comment. In D20655#647806 , @davidedmundson wrote: > We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make it optional whi

D20655: Use generated DBus interface

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make i

D20655: Use generated DBus interface

apol added a comment. UPower already installs the xml files. Wouldn't it be better to use the installed xml instead of providing our own? INLINE COMMENTS > upowerdevice.cpp:35 > > +#include > + unneeded? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20655 To:

D20655: Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids introspection calls when creating the manager or devi