davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make it optional which only introduces more real-world bugs. It also means future devs know what we were compiled against. Marking as requesting changes for the extra include, but personally I think it's generally good to go. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20655 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
