bruns added a comment.
In D20655#647806 <https://phabricator.kde.org/D20655#647806>, @davidedmundson wrote: > We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make it optional which only introduces more real-world bugs. It also means future devs know what we were compiled against. > > Marking as requesting changes for the extra include, but personally I think it's generally good to go. We are also already copying part of the interface specification. After all, `indexOfSignal("DeviceAdded(QDBusObjectPath)")` is the same as the corresponding code generated by dbusxml2cpp. Two more change requests: - Please mention support for the deprecated `DeviceAdded(string)` (upower < 0.99) is removed - Please wrap long lines in the summary etc. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20655 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
