nt*
kioclient6 -> kioclient*
or, if there is no need now for KF5 compatibility, just:
kioclient*
kioclient6 -> kioclient*
I'd be happy to submit any MRs needed, but first just wanted to check
that there are no hidden reasons why the installation is done this way.
--
Jonathan Marten http://www.keelhaul.me.uk
Twickenham, UK j...@keelhaul.me.uk
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6452a34cf01d: Fix service file specifying 'Run in
terminal' giving an error code 100 (authored by marten).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29738?vs=82823
marten created this revision.
marten added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
https://bugs.kde.org/show_bug.cgi?id=421374 describes how a service file
spec
marten added a comment.
I've thought about this a bit more and can't find any explanation as to why
the DBus signal does not loop back to the sending process as well as all other
listeners. It may be an unspecified detail of the DBus implementation that
could possibly change at any time and
marten added a comment.
I'm happy to work on the refactoring if you think it's the right thing to do.
Do you mean splitting SchedulerPrivate::slotReparseSlaveConfiguration() up
into two halves, the first part (KProtocolManager::reparseConfiguration through
to NetRC::self()->reload - repa
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0a5dd2972b62: Allow building from a read-only source
location (authored by marten).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28755?vs=79867&id=80219
REV
marten updated this revision to Diff 79867.
marten added a comment.
Yes, that would mean fewer changes to the validate_svg.sh script.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28755?vs=79845&id=79867
REVISION DETAIL
https://phabricator.kde.org/
marten created this revision.
marten added a reviewer: Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
In the situation, for example, where a master source tree may be shared among
a number o
marten created this revision.
marten added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
I've been looking at porting Konqueror's User Agent Changer plugin to current
marten added a comment.
@ahmadsamir: Yes, the problem could be fixed in Dolphin, but that leaves a
potential trap for any other KPart that reimplements openUrl().
As a minimum, if it is decided that the fix belongs in the application then
KParts::ReadOnlyPart should have a caution in the
marten added a comment.
Yes, I'd concluded that the real place to fix the problem was at the KParts
level, but not being a KParts expert wanted to leave that decision to its
maintainers. +1 for the elegant fix.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D27148
marten abandoned this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D7820
To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, plasma-devel, aprcela, fprice, LeGast00n,
sbergeron, jraleigh, fbampaloukas, alexde, GB_2, feverfew, ragre
marten added a comment.
Confirmed that man:clang(1) now correctly displays the man page with no
spurious numbers shown. Would be happy to abandon this review request.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D7820
To: marten, #plasma, kfm-devel, mkoller
Cc
marten abandoned this revision.
marten added a comment.
Appears to have been already implemented by
https://phabricator.kde.org/R244:b2b873d612a018d33866ddfd497f87bb7dd79573
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D19332
To: marten, #frameworks
Cc: apol,
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:1b56cc62c93d: kio_smb: Change incorrect use of
QUrl::adjusted() (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19439?vs=52884&id=54927
REV
marten added a comment.
Ping - anyone able to review please?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19439
To: marten, #plasma, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh,
spoorun, navarromorales, firef, ngraham, an
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:534ebe58c4ca: Delete/Trash confirmation dialogue: Fix
misleading title (authored by marten).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19847?vs=54145&id=54178
REV
marten created this revision.
marten added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
The misleading title that brought this dialogue to my attention is where
ther
marten updated this revision to Diff 52898.
marten added a comment.
Use the same condition as the Qt header uses
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19332?vs=52601&id=52898
REVISION DETAIL
https://phabricator.kde.org/D19332
AFFECTED FILES
marten added a reviewer: kfm-devel.
Herald added projects: Dolphin, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D7820
To: marten, #plasma, kfm-devel
Cc: kde-frameworks-devel, plasma-devel, jraleigh, alexd
marten added a reviewer: kfm-devel.
Herald added projects: Dolphin, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D9033
To: marten, #plasma, kfm-devel
Cc: kde-frameworks-devel, apol, plasma-devel, jraleigh,
marten created this revision.
marten added reviewers: Plasma, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
Compiling this module produces a number of warnings all refe
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:604a2f402da7: Check string length to avoid crash for
"tags:/" URL (authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19371?vs=52681&id=52703#toc
REPOSITORY
R293 Baloo
CHAN
marten created this revision.
marten added a reviewer: Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
Bug https://bugs.kde.org/show_bug.cgi?id=400594 was fixed by
https://commits.kde.or
marten added inline comments.
INLINE COMMENTS
> apol wrote in kprocess.h:332
> Also should check for QT_DISABLE_DEPRECATED_BEFORE no?
Do you mean conditionalise instead on #if !QT_DEPRECATED_SINCE(5, 13), so that
if the functions are not disabled in Qt then they are hidden here? That would
wo
marten created this revision.
marten added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.
REVISION SUMMARY
The functions QProcess::setReadChannelMode() and QProcess::readChannelMode()
are obs
marten added a comment.
In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
> Are the copies in the attic directory still needed for compatibility
reasons, or can they get removed?
No needed by anything within Frameworks, Plasma or Applications as far as I'm
aware. Shall
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ee5b036c1df4: Add FindGLIB2.cmake and
FindPulseAudio.cmake (authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7823?vs=19611&id=21961#toc
REPOSITORY
R240 Extra CMake Modules
marten added a comment.
Ping anyone?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
marten added a comment.
FYI: KMail uses Ctrl+comma and Ctrl+dot as standard shortcuts for "Collapse
all threads" and "Expand all threads" respectively.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: marten, graesslin, broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c76c1486ec79: kioexec: Watch the file when it has
finished copying (authored by marten).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7841?vs=19864&id=19885
REVISION
marten updated this revision to Diff 19864.
marten added a comment.
Updated in accordance with review comments. Go easy - it's the first lambda
that I've submitted...
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7841?vs=19565&id=19864
REVISION DETAIL
htt
marten marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7841
To: marten, #frameworks, dfaure
Cc: elvisangelaccio, dfaure
marten marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
marten updated this revision to Diff 19611.
marten added a comment.
Diff updated to move library target definition after
find_package_handle_standard_args.
If these modules are accepted into ECM then KMix needs a further commit
anyway, in order to remove the final requirement for KDELibs
marten marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
marten updated this revision to Diff 19576.
marten marked an inline comment as done.
marten added a comment.
Updated as per review comments.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7823?vs=19570&id=19576
REVISION DETAIL
https://phabric
marten marked 17 inline comments as done.
marten added a comment.
Diff updated.
INLINE COMMENTS
> cgiboudeaux wrote in FindPulseAudio.cmake:8-19
> It's a new module, change PULSEAUDIO to PulseAudio to match the module name.
PULSEAUDIO -> PulseAudio changed throughout
REPOSITORY
R240 Extra
marten updated this revision to Diff 19570.
marten added a comment.
Modules updated with standard header, documentation and copyright; endif()
used throughout.
Yes, Phonon does not use ECM but the modules there are very different to
those in ECM anyway.
Within Plasma+applications thes
marten created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
As described in bug https://bugs.kde.org/show_bug.cgi?id=384500, there
appears to be a problem when the receiving application of a file needs a
temporary copy to be made (because of %F/%f in its
marten added a comment.
It's the same source really - the only differences between those in
kdelibs4support and ecm/attic are that the former uses endif(same_as_if) and
the latter uses endif().
Nothing else within Frameworks, Plasma or applications uses anything from
ecm/attic directly.
R
marten added a subscriber: heikobecker.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: heikobecker
marten created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
These modules are used in a number of places within Frameworks, Plasma and
dependencies:
FindGLIB2:
plasma-desktop/applets/kimpanel/cmake/FindGLIB2.cmake
kdelibs4suppo
This revision was automatically updated to reflect the committed changes.
Closed by commit R267:1b641f89d752: Remove obviously wrongly-named symbolic
links (authored by marten).
REPOSITORY
R267 Oxygen Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5871?vs=14560&id=14564
REVISI
marten created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It's not clear where these entries came from, but they are clearly a mistake
- either scripting or copy-and-paste.
The
This revision was automatically updated to reflect the committed changes.
Closed by commit R226:c27a79e2dbab: Restore the ability to select Konqueror as
the default file manager (authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4463?vs=10973&id=10978#toc
REPOSITORY
R
marten created this revision.
marten added reviewers: Frameworks, dfaure.
marten set the repository for this revision to R226 Konqueror.
REVISION SUMMARY
Konqueror was originally able to be selected as the default file manager by
using kcmshell5 componentchooser ("Default Applications"). Now i
marten added a comment.
Agreed that a decision needs to be made, but I'm not an expert on the
KPackage system and so wasn't sure whether the warning may be useful to package
developers in some cases - in which case leaving it commented out would make it
easier to reinstate than removing it e
marten created this revision.
marten added reviewers: Frameworks, Plasma.
marten set the repository for this revision to R290 KPackage.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As described in https://bug
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:10179358b617: Bug reporter: Allow a URL (not just an
email address) for custom reporting (authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4072?vs=9992&id=10215#toc
REPOSITO
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:bbf76499d9e2: KAboutData: Document that bug email address
can also be a URL (authored by marten).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4080?vs=10032&i
marten added a dependent revision: D4080: KAboutData: Document that bug email
address can also be a URL.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D4072
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten, #frameworks
Cc: aa
marten added a dependency: D4072: Bug reporter: Allow a URL (not just as an
email address) for custom reporting.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4080
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten, #frame
marten created this revision.
marten added a reviewer: Frameworks.
marten set the repository for this revision to R244 KCoreAddons.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Differential https://phabricator.kde.org/D4072 requests a change to the bug
reporting system i
marten added a comment.
Yes, I'll submit a separate diff for that. Fortunately BC, since there are
no actual code changes needed - only the parameter name. The getter/setter
bugAddress/setBugAddress will suffice as they are (with apidoc changes).
REPOSITORY
R263 KXmlGui
REVISION DETAIL
marten created this revision.
marten added a reviewer: Frameworks.
marten set the repository for this revision to R263 KXmlGui.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The rather old bug https://bugs.kde.org/show_bug.cgi?id=277142, although
raised against KDE4 kdeli
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 842ac3256137b0d4fde129844ff6d5aac9da0090 by Jonathan
Marten to branch master.
Repository: khtml
Description
---
This is currently built and installed, but it is not usable
e embedded viewer part in
Konqueror and other applications.
Thanks,
Jonathan Marten
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 3f7465b8d7c1649b54eb6ce72e88d2a3080e2234 by Jonathan
Marten to branch master.
Repository: kconfigwidgets
Description
---
This function is intended to return the action for the StandardAction of
hanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 75a55d449f2f070c5410e47a9529a984403c3297 by Jonathan
Marten to branch master.
Repository: kdelibs4support
Description
---
In KDE4 this widget displayed the appropriate country flag at the start
dialogue.
Thanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit ab2f9fb2b7780c913a417b01700e33d3bb986f9c by Jonathan
Marten to branch master.
Repository: kparts
Description
---
This dialogue is used, e.g. in Konqueror, when asking to open
-bc92-f0da3b9b5b3e__konqueror-openwith-frameworks-breeze-after.png
Thanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
those three still on
> > the first level and then a "More..." option with further actions?
>
> Jonathan Marten wrote:
> I wouldn't have said "rarely used": certainly in my experience I use all
> of these options occasionally, but
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/#review92299
---
On Feb. 11, 2016, 6:18 p.m., Jonathan Marten wrote:
>
> -
1/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
Popup menu after
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png
Thanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 5ac5dfb28014035e3704ae8bf8076001e5955ceb by Jonathan
Marten to branch master.
Bugs: 355711
https://bugs.kde.org/show_bug.cgi?id=355711
Repository: kparts
Description
---
This appears to
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 1ae59b5f0ea4f50b7350f03fd2b1fe223f66a261 by Jonathan
Marten to branch master.
Bugs: 352471
https://bugs.kde.org/show_bug.cgi?id=352471
Repository: kcmutils
Description
---
The API
logue as described in the bug report. Observed assert/crash
without this change, and correct operation with it.
Thanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ed
change (see associated review). Observed no crash when exiting the
application. Also checked correct operation of Konqueror and Kate.
Thanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kd
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit ed61726878fc6a4cd9f2741e3ab67db34f78f0ca by Jonathan
Marten to branch master.
Repository: kio
Description
---
The "You received a cookie from..." dialogue appears, but there are a
details was not being saved correctly. Using
!isHidden() instead of isVisible() gets the correct information.
Diffs
-
src/ioslaves/http/kcookiejar/kcookiewin.cpp 56a283f
Diff: https://git.reviewboard.kde.org/r/126245/diff/
Testing
---
Built kio with these changes, checked oper
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 3bdd02a2fbcac6d7bc6a188ce2396160c4f22ed7 by Jonathan
Marten to branch master.
Repository: kio
Description
---
When starting this module, from the command line or similar, the error message
is
correctly.
Thanks,
Jonathan Marten
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
75 matches
Mail list logo
