marten added inline comments. INLINE COMMENTS
> apol wrote in kprocess.h:332 > Also should check for QT_DISABLE_DEPRECATED_BEFORE no? Do you mean conditionalise instead on #if !QT_DEPRECATED_SINCE(5, 13), so that if the functions are not disabled in Qt then they are hidden here? That would work, although QT_DEPRECATED_SINCE is not public API or defined in the Qt documentation. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19332 To: marten, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
