marten updated this revision to Diff 19611. marten added a comment.
Diff updated to move library target definition after find_package_handle_standard_args. If these modules are accepted into ECM then KMix needs a further commit anyway, in order to remove the final requirement for KDELibs4Support. So the correct variable names can be set at this point (I have already tested this configuration). Other packages requiring PA and/or GLib may need to do the same when transitioning to use the ECM versions. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7823?vs=19576&id=19611 REVISION DETAIL https://phabricator.kde.org/D7823 AFFECTED FILES find-modules/FindGLIB2.cmake find-modules/FindPulseAudio.cmake To: marten, #frameworks, #build_system Cc: cgiboudeaux, cfeck, heikobecker
