to Phabricator since
Reviewboard is deprecated since some time.
- Gregor Mi
On Dez. 24, 2016, 12:49 nachm., Luke Dashjr wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
marked as submitted.
Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus.
Changes
---
Submitted with commit fa6bad3be579ec89c8126b00438234d0bc16c508 by Gregor Mi to
branch master.
Bugs: 335616
https://bugs.kde.org/show_bug.cgi?id=335616
Repository: kio
nerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review100988
---
On July 27, 2017, 11:15 a.m., Gregor Mi wrote:
>
> ---
> This is an automatically ge
igator.cpp 033046f06dd5bea3f4124669c55803aba3a31789
src/filewidgets/urlutil_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127111/diff/
Testing
---
Thanks,
Gregor Mi
managers to pre-select the
> > directory that the user is navigating up from".
That sounds better. Fixed in the coming update.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review92587
ilewidgets/kurlnavigator.cpp 3c045c5aaadb429fd22d28b55ad20d31b086ef48
src/filewidgets/urlutil.h PRE-CREATION
tests/CMakeLists.txt bc94a4aefd77fb9ce9b2a24075415aac7c30e5ca
tests/urlutiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127111/diff/
Testing
---
Thanks,
Gregor Mi
Faure wrote:
> Gregor, do you plan on updating the patch based on the above conclusions?
> Thanks.
Yes, I do. It is still on my list. Sorry for not to have responded earlier.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12711
but maybe I'm wrong) is:
>
> First user case: Check a file. You paste your checksum, and without
> clicking anything it goes red or green (or with a small message) and tells
> you if it's the good checksum. This mean that you don't need to hit any
> [calculat
but maybe I'm wrong) is:
>
> First user case: Check a file. You paste your checksum, and without
> clicking anything it goes red or green (or with a small message) and tells
> you if it's the good checksum. This mean that you don't need to hit any
> [calculat
but maybe I'm wrong) is:
>
> First user case: Check a file. You paste your checksum, and without
> clicking anything it goes red or green (or with a small message) and tells
> you if it's the good checksum. This mean that you don't need to hit any
> [calculat
but maybe I'm wrong) is:
>
> First user case: Check a file. You paste your checksum, and without
> clicking anything it goes red or green (or with a small message) and tells
> you if it's the good checksum. This mean that you don't need to hit any
> [calculat
but maybe I'm wrong) is:
>
> First user case: Check a file. You paste your checksum, and without
> clicking anything it goes red or green (or with a small message) and tells
> you if it's the good checksum. This mean that you don't need to hit any
> [calculat
but maybe I'm wrong) is:
>
> First user case: Check a file. You paste your checksum, and without
> clicking anything it goes red or green (or with a small message) and tells
> you if it's the good checksum. This mean that you don't need to hit any
> [calculat
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the groupbox is
> > unnecessary and confusing.
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128466/#review97475
---
This suggestion sounds reasonable. I like it.
- Gregor Mi
> On May 30, 2016, 5:54 a.m., Martin Gräßlin wrote:
> > Kind of unrelated: do you have ideas how we can integrate the "Donate" into
> > applications which don't have a help menu, like Plasma or KWin?
>
> Albert Astals Cid wrote:
> I don't see "obvious" places for things without much chrome
questions.
- Gregor Mi
On May 11, 2016, 11:01 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
tps://git.reviewboard.kde.org/r/127887/#comment64748>
I don't know if this does the same but also didn't test.
src/kmoretools/kmoretoolsconfigdialog_p.cpp (line 201)
<https://git.reviewboard.kde.org/r/127887/#comment64749>
I wonder why here "for" is better than Q_FOREACH.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127237/#review93309
---
Ship it!
- Gregor Mi
On March 7, 2016, 8:38 p.m., Kåre
> On March 7, 2016, 9:29 p.m., Gregor Mi wrote:
> > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129
> > <https://git.reviewboard.kde.org/r/127237/diff/2/?file=448481#file448481line128>
> >
> > Thanks for the comment. However, as long as we don't
s a comment.
That said I don't know what the KDE policy is when dealing with this kind
of problem. Just adding null checks seems to make the code more complicated to
analyse later. You are a long-term committer, so your words have a high weight.
On the other hand I would be interested i
-
>
> (Updated March 1, 2016, 6:50 a.m.)
>
>
> Review request for KDE Frameworks and Gregor Mi.
>
>
> Repository: knewstuff
>
>
> Description
> ---
>
> If DBus is missing we get null-pointers in stead of KMoreToolsService*. This
> patch adds chec
0094969b5c
tests/urlutiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127111/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-
Am 01.06.2015 09:48 schrieb David Faure:
On Thursday 21 May 2015 14:41:27 Gregor Mi wrote:
private:
-// Note that this object must live long enough in case the user
opens
-// the "Configure..." dialog
-KMoreTools* m_kmt = nullptr;
-
-QMenu* m_menu
Hi David,
I just commited a fix for the unit tests.
> In fact, is tests/kmoretoolstest supposed to be a unittest ?
It has both unittests and interactive dialogs in it. The interactive dialogs
can be
disabled via a flag but I guess I should separate this more cleanly.
> but releasing something
Hi,
I would like to add that there are other much bigger frameworks which have a
lot more
resources at hand and also have one single version under which all of the many
submodules
are released:
Java (Java 6, Java 7, Java 8, ...)
https://en.wikipedia.org/wiki/Java_version_history
.NET (3.0, 3.
> On April 18, 2015, 9:29 p.m., Gregor Mi wrote:
> > Ship It!
Thanks for also taking care of the commments/documentation. There is some more,
which I will do later.
- Gregor
---
This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123421/#review79182
---
Ship it!
Ship It!
- Gregor Mi
On April 18, 2015, 7:45 p.m
g
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On April 17, 2015, 7:18 a.m., Gregor Mi wrote:
> > I did not receive an email on the final code changes. So this should
> > trigger another one.
>
> Gregor Mi wrote:
> .
(still no email received. sorry for the pot
> On April 17, 2015, 7:18 a.m., Gregor Mi wrote:
> > I did not receive an email on the final code changes. So this should
> > trigger another one.
.
- Gregor
---
This is an automatically generated e-mail. To repl
should trigger
another one.
- Gregor Mi
On April 17, 2015, 7:07 a.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
a11e
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
a11e
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit b87e1772ee39c7edc002636a8ae35e09047308e4 by Gregor Mi to
branch master.
Repository: knewstuff
Description
---
Moved from kservice (https://git.reviewboard.kde.org/r/122576
ng PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
org/r/122910/#review78995
---
On April 15, 2015, 8:24 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
retools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
T
oretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-framew
n next RR update or commit.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78777
---
On April
ck considering the
surrounding code, what do you think?
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/#review78473
-------
> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
> > src/kglobalaccel.h, line 260
> > <https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260>
> >
> > typo in following
>
> Gregor Mi wrote:
> About wh
tps://git.reviewboard.kde.org/r/122981/#comment53681>
NOTE that this causes compile error in libKF5XmlGui
/home/gregor/dev/kf5/usr/lib64/libKF5XmlGui.so.5.8.0: undefined reference
to `KGlobalAccel::globalShortcutChanged(QAction*, QKeySequence const&)'
collect2: error: ld returned 1 exit statu
> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
> > src/kglobalaccel.h, line 260
> > <https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260>
> >
> > typo in following
>
> Gregor Mi wrote:
> About wh
> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
> > src/kglobalaccel.h, line 260
> > <https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260>
> >
> > typo in following
>
> Gregor Mi wrote:
> About wh
src/kglobalaccel_p.h eca7c52378ad60d0d5806561214b9788dd46a11e
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
-------
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/
all other unit tests in ./kservicetest sill succeed
3. Call `kbuildsycoca5 --noincremental` without and with the patch and try out
dolphin's Space Info menu. In the first case filelight is not found. With the
patch filelight is found.
Thanks,
Gregor Mi
_
matically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/#review78424
---
On April 2, 2015, 11:55 a.m., Gregor Mi wrote:
>
> ---
> This is an automaticall
E-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/li
caff77156b
src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16
src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel ma
> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
> > src/kglobalaccel.h, line 260
> > <https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260>
> >
> > typo in following
>
> Gregor Mi wrote:
> About wh
Settings" again.
So the question is: How can I unregister the value retrieved by the method
"getGlobalShortcutsByKey"? This would also fix the unit tests.
- Gregor Mi
On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
>
> --
the SendTo... button and see debug output:
m_pluginLoader->init()
KIPI_FOUND...
m_pluginLoader->loadPlugins();
... pluginList.count() 0
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.k
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/#review78259
---
On March 30, 2015, 9:22 p.m., Gregor Mi wrote:
>
>
e first case filelight is not found. With the
patch filelight is found.
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
dsycoca5 --noincremental` without and with the patch and try out
dolphin's Space Info menu. In the first case filelight is not found. With the
patch filelight is found.
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/#review78263
-------
On March 30, 2015, 9:22 p.m., Gregor Mi wrote:
>
>
23095/diff/
Testing
---
Run ksnapshot, click the SendTo... button and see debug output:
m_pluginLoader->init()
KIPI_FOUND...
m_pluginLoader->loadPlugins();
... pluginList.count() 0
Thanks,
Gregor Mi
___
Kde-frameworks-devel maili
are verifications on
> > whether kglobalacceld is running.
>
> Gregor Mi wrote:
> Now 4 other tests fail. Can you give me a quick hint if there is some
> persistent settings used by the unit tests which I can delete?
I tried this to debug one of the failing test cases:
$ strace -o
> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
> > src/kglobalaccel.h, line 260
> > <https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260>
> >
> > typo in following
>
> Gregor Mi wrote:
> About wh
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77912
-------
On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
>
> -
enerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77902
---
On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
>
> ---
> This is an automati
e4ec6ceb0bb9e54235aef7f1aeeb8c16
src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-------
On March 21, 2015, 12:39 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122981/
>
/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
> > src/kmoretools/kmoretools.h, line 394
> > <https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line394>
> >
> > Do we need the kmt-prefix? Why not just
> > KMoreToolsSe
N
tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
_
1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--------
On March 16, 2015, 8:29 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122981/
> -
https://git.reviewboard.kde.org/r/122981/#review77606
-----------
On March 16, 2015, 8:29 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mai
3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16
src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
st.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
pp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailma
www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdreturn).
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
-------
It generates 3
headings (Introduction, Details and TODOs). Nevertheless, I also see now that
there are plenty of issues to be fixed when I look at the generated
documentation.
- Gregor
---
This is an automatically generat
ened issues and I will create my own ones for specific questions
where a second opinion would be nice.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review
tps://git.reviewboard.kde.org/r/122910/#comment53239>
The QAction should be created at first usage. But it must be destroyed when
the menu is cleared. I am not sure if this is a good way of doing it.
- Gregor Mi
On March 11, 2015, 11:06 p.m., Gregor Mi
omatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
---
On March 11, 2015, 11:06 p.m., Gregor Mi wrote:
>
> ---
/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde
ION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
- Gregor Mi
On March 1, 2015, 2:28 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
t; needed (it's our current implementation of that) but KMT itself isn't part
> > of the ksycoca technology, it should be higher up in the stack.
> >
> > One idea would be to put it in KNewStuff. It's the same kind of thing,
> > viewed from far aw
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review77147
-------
On March 1, 2015, 2:28 p.m., Gregor Mi wrote:
>
>
> > QtWidgets.
I think so, too. Any other idea?
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76114
--------
/kate.png PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
/kmoretools/kmoretools.cpp PRE-CREATION
src/kmoretools/kmoretools_p.h PRE-CREATION
src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks
/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
t:
https://git.reviewboard.kde.org/r/122576/#review76422
-------
On Feb. 16, 2015, 11:05 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To repl
s/ui/kmoretoolsconfigwidget.ui PRE-CREATION
tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e
tests/kmoretools/1/a.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-framew
ght they
were reference counted.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76158
---
On Feb. 16, 2
/kmoretoolsconfigdialog.h PRE-CREATION
src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION
src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde
N
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
;Open all recent files". What about hide it by default
and let the client (kate, kaffeine etc.) decide if it should be shown or not by
- e.g. with .setOpenAllMenuItemVisible(true); or .setAllowOpenAll(true);
- Gregor Mi
On Feb. 12, 2015, 11:56 p.m., Thomas Mu
21831/: This also
causes a BIC change and would therefore also require an SOVERSION bump. I am
wondering if another SOVERSION change would be good regarding having stable KDE
APIs. Is there a certain point in time when APIs like this one should not
change anymore?
- Gregor Mi
On Jan. 15, 2015,
: [kwidgetsaddons/removeicon1] src: Remove top right icon from KPageView
Date: Fri, 12 Dec 2014 11:04:16 +
From: Gregor Mi
Reply-To: kde-comm...@kde.org
To: kde-comm...@kde.org
Git commit 7bf344b5137e419a5caab42c346a0eb20e5912e6 by Gregor Mi.
Committed on 07/12/2014 at 10:32.
Pushed by gregormi
he set icon)
> please ignore (sorry again)
>
> For what its worth, I'm not so happy with the change still (I liked the
> icon). But thats only a matter of taste and without rational.
>
> Gregor Mi wrote:
> Thanks for clarifying. :-)
>
> Christoph Feck wr
1 - 100 of 126 matches
Mail list logo
