> On April 15, 2015, 8:39 p.m., Jeremy Whiting wrote: > > Ship It!
> As KMoreTools is going to be part of KNewStuff it should be using > KNEWSTUFF_EXPORT not KSERVICE_EXPORT. The install dir now looks like this: http://wstaw.org/m/2015/04/15/plasma-desktopVd2099.png I wonder if this ok to have a duplicate knewstuff_export.h? Or should the files go into the "kns3/KNS3" subdirectory? - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78995 ----------------------------------------------------------- On April 15, 2015, 8:24 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122910/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 8:24 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here > (knewstuff). > > Example usages: > - dolphin's SpaceInfoToolsMenu: https://git.reviewboard.kde.org/r/122911/ > - kate's project addin: https://git.reviewboard.kde.org/r/122374/ > - ksnapshot's SendTo menu: https://git.reviewboard.kde.org/r/123342/ - Note, > that here the "Not installed" functionality is not used at all. But this > use-case takes advantage of the built-in "Configure menu" feature. > > > Diffs > ----- > > docs/pics/kmoretools-kate-project-1-all-installed.png PRE-CREATION > docs/pics/kmoretools-kate-project-2-two-not-installed.png PRE-CREATION > docs/pics/kmoretools-kate-project-3-config-dialog-all-installed.png > PRE-CREATION > src/CMakeLists.txt 3b9a403eb473e0c3760506b2757c71d603b99775 > src/kmoretools/kmoretools.h PRE-CREATION > src/kmoretools/kmoretools.cpp PRE-CREATION > src/kmoretools/kmoretools_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION > src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION > tests/CMakeLists.txt 103c5fc98deaf83288b843cc66a87f2d95ad9dfb > tests/kmoretools/1/a.desktop PRE-CREATION > tests/kmoretools/1/b.desktop PRE-CREATION > tests/kmoretools/1/c.desktop PRE-CREATION > tests/kmoretools/2/kate.desktop PRE-CREATION > tests/kmoretools/2/kate.png PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION > tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION > tests/kmoretools/kmoretoolstest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122910/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
