> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 287 > > <https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line287> > > > > @return, never @returns. > > > > Further, can you be mor verbose? > > > > @return Returns the tools service ... .... The returned pointer may be > > a nullptr.
About "never use @returns": I can fix it but is there a specific reason? Because it is part of the doxygen spec (http://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdreturn). - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review77502 ----------------------------------------------------------- On March 11, 2015, 11:06 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122910/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 11:06 p.m.) > > > Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here > (knewstuff). > > Example usages: > - dolphin's SpaceInfoToolsMenu: https://git.reviewboard.kde.org/r/122911/ > - kate's project addin: https://git.reviewboard.kde.org/r/122374/ > > > Diffs > ----- > > src/CMakeLists.txt 3b9a403eb473e0c3760506b2757c71d603b99775 > src/kmoretools/kmoretools.h PRE-CREATION > src/kmoretools/kmoretools.cpp PRE-CREATION > src/kmoretools/kmoretools_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION > src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION > tests/CMakeLists.txt 103c5fc98deaf83288b843cc66a87f2d95ad9dfb > tests/kmoretools/1/a.desktop PRE-CREATION > tests/kmoretools/1/b.desktop PRE-CREATION > tests/kmoretools/1/c.desktop PRE-CREATION > tests/kmoretools/2/kate.desktop PRE-CREATION > tests/kmoretools/2/kate.png PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION > tests/kmoretools/kmoretoolstest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122910/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
