February
Due to the delay of KDE Gear by an additional patch release of 23.08
will be made.
David Edmundson
As a reminder this meeting is tonight in 3 hours.
David
Video call at https://meet.kde.org/b/ada-mi8-aem
A time has been chosen on the poll with a clear winner:
4th September 18:00 CEST
See you all there
David Edmundson
e to have a vote with multiple rounds of
elimination.
Open discussion ahead of time is available at:
https://invent.kde.org/teams/frameworks-devs/kf6-workboard/-/issues/55
David Edmundson
For kwayland I would suggest to keep it in it's own repo kept being
called kwayland
Dialog is in Plasma-framework which is moving to workspace anyway. I'm
not sure of the status of that move is.
I would put suggest putting D&D stuff in plasma-framework (or whatever
it ends up being called)
Updates on this topic after the plasma BOF.
There's some concerns (by me mostly) about Plasma being committed to a
rigid schedule. As such the following was somewhat agreed upon.
We can probably delay the .12 release of KDE Gear if it's needed. The
Qt 6 transition is a special case.
If we want to
They're in a short format, ping if there's any questions.
# Timelines
KDE Gear 0.8 will be Qt5 ONLY
KDE Gear .12 should be Qt5 and Qt6
Will REQUIRE plasma to be out (for themes and stuff).
Plasma timing discussion is tomorrow, so that maybe throws things out.
Apps should keep master as Qt5 and
On Fri, Apr 28, 2023 at 5:59 PM Jonathan Riddell wrote:
>
> The deconflictor job we run in neon still has a bunch of files overlapping
> between kf5 and kf6
>
> https://build.neon.kde.org/job/test_kf6_deconflictor/
>
> https://build.neon.kde.org/job/test_kf6_deconflictor/9/artifact/conflict-repor
Please ensure you are building with
-DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.91.0
There is now a "kf5" branch in all frameworks repos as discussed last
frameworks meeting.
Starting now any commits that are also wanted in the next KF5 should
be cherry-picked after landing.
This does *not* mean master is fully open for going into KF6 dev mode.
Now the kf5 branches exist, we'll s
I'm sure everyone is excited:
Full schedule and joining instructions available at:
https://invent.kde.org/plasma/plasma-workspace/-/issues/32
Looking forward to seeing your all
David
We have examples of where we have done this. Though I wouldn't
necessarily use the word "properly".
In Plasma-framework we have a manually made list where we can write
the plugin name and list items by their exported QML type name.
https://invent.kde.org/frameworks/plasma-framework/-/blob/master/
Excellent news!! Thanks very much
> Once the scripts have been proven successfully for Frameworks, we will look
> at extending them to projects that depend only on Frameworks and repositories
Does this mean we would like Plasma to wait a while before merging?
Is it worth us creating the kde-cli
> It seems these days the only real user of plasma-frameworks & krunner
> libraries is the Plasma shell itself, with other applications only providing
> plugins/extensions and only targeting Plasma again.
That is mostly in line with other discussions in plasma. There is a
ticket splitting plasma-f
I wanted to bump this thread, just so people remember that it is this weekend!
There are many many slots still available.
David
> > (where 1000 is of course dynamic)
>
> Ditto, what enum names could we give to those?
/ -> All
/system.slice -> System
user.slice/user-1000.slice/user@1000.service -> User
user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps
user.slice/user-1000.slice/user@1000.service/session.sli
One down:
https://invent.kde.org/frameworks/kirigami/-/merge_requests/200
On Sun, 20 Dec 2020, 11:48 Friedrich W. H. Kossebau,
wrote:
> (Added Han Young as BCC: based on code email address, as the task is not
> public, and not sure you are subscribed to the mailinglists)
>
> Am Sonntag, 20. Dezember 2020, 12:05:46 CET schrieb David Edmundson:
> >
Please see https://community.kde.org/Policies/Application_Lifecycle about
the process of adding things to frameworks.
As for plasma, we have a weather library there, so the comment about it
being easier for new plasmoids doesn't hold directly. Maybe you can expand
on what's different?
David
On Thu, Dec 3, 2020 at 11:48 AM Kevin Ottens wrote:
>
> Hello,
>
> On Thursday, 3 December 2020 12:15:52 CET David Edmundson wrote:
> > Ultimately this isn't really dealing with cgroups directly but with
> > the manager to control them, systemd.
> >
>
Ultimately this isn't really dealing with cgroups directly but with
the manager to control them, systemd.
That's correct usage, kernel docs of cgroups say to go via a
controller for write operations. However that at point is it worth
naming the library ksystemd?
It might cause some contention due
change made:
https://invent.kde.org/plasma/kwayland-server/-/merge_requests/133
>If the user was idle for a second (using a KIdleTime timeout), I start my own
>idle time counter (counter++ every second).
>Then I catch the next resume event (next user input) and reset my counter to 0.
That sounds like what I had in mind.
> 2) It works with XWayland, but only detects user act
>
> Yes, I meant that progress bar.
> I've had that 1s idle timer idea as well, unfortunately after writing this,
> but thank you for confirming that this would indeed work.
> I will give that a try and if I can get RSIBreak to a working state on
> wayland submit a PR for it.
Excellent, thank yo
> I agree, if we can't make the KIdleTime framework work in Wayland there
> should be a way to query the framework if it's going to work or not.
Just to make sure that's not misread by others; the framework works
for the majority of methods used in the common case, just not this one
polling metho
My fault. Fix on review.
David
Urgh, let me just remove that test.
No-one will even use that protocol soon anyway.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
port-to-shadows-api
REVISION DETAIL
https://phabricator.kde.org/D26503
To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, m
davidedmundson added a comment.
Moved to invent.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28355
To: davidedmundson, #build_system
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n,
cblack, bencreasy, michaelh, ngraham, bru
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:2976b27a6c0b: Introduce function
ecm_install_configured_file (authored by davidedmundson).
REPOSITORY
R240 Extra CMa
davidedmundson added a comment.
> the runner "backend" is used (from the QML side of things).
Repo is called milou
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29228
To: broulik, #frameworks, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
davidedmundson added a comment.
> that would probably mean recompiling most of KDE (Debian has packages for
5.69 only). I will check out your change and see what remains.
This isn't a universal rule that always applies, but generally speaking you
can just roll back the the frameworks ver
davidedmundson added a comment.
Your base kcrash is quite out of date - I simplified this method considerably
a month ago, which gets rid of the two paths.
Also can you check your commit messages, I don't know if it's phab being
weird, but they all start with "t/" in the phab UI,
REPOSI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29034
To: broulik, #plasma, #frameworks, davidedmundson
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngr
We seem to have a common crasher newly introduced in plasma-framework. A
dozen reports in a few days.
Can I ask for a plasma-framework 5.70.1. with
c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked.
Sorry.
David
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c215c54eced5: Avoid potential disconnect of all signals
in IconItem (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
m_svgIcon can be null.
disconnect(q, nullptr, nullptr, nullp
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f2b0dcdefea7: Fix modified line marker in kate minimap
(authored by davidedmundson).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29680?vs=82663&id=82717
REVIS
davidedmundson added a comment.
What about ktexteditor?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D29680
To: davidedmundson, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,
domson, michaelh, bruns, demsking, cullmann, sars,
davidedmundson created this revision.
davidedmundson added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Our pixmap is the size of the number of lines in
davidedmundson added inline comments.
INLINE COMMENTS
> cblack wrote in configmodule.h:98
> You probably want to use backticks instead of quotes as this is referring to
> something codewise.
I don't understand.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D2940
davidedmundson added a comment.
Seems sensible, given it's valid to have an empty context.
I don't know enough about icons to know all possible ill effects. If there's
no other comments in a few days consider this a "ship it!"
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phab
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c730edc8dce4: Port KKeySequenceItem to QQC2 (authored by
davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29292?vs=81557&id=82604
REVISION DETA
davidedmundson requested changes to this revision.
davidedmundson added a comment.
Plasmacomponents is deprecated please see Plasmacomponents3 then see the
readme within that and put this somewhere else.
1. Label is a super super super common element we don't want to add any
overhead ins
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29503
To: fvogt, #frameworks, broulik, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh
davidedmundson added a comment.
Relevant link on that last comment:
https://bugreports.qt.io/browse/QTBUG-63331
They actively seeked our opinion on colour roles
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D25814
To: ndavis, #frameworks, #vdg
Cc: ahiem
davidedmundson added a comment.
> Allow users of KPreviewJob to request a devicePixelRatio for generated
thumbnails.
At the risk of asking a stupid question, why?
As opposed to just having a width and height always be in device pixels.
We're always working with pixmaps is there a re
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29409
AFFECTED FILES
src/q
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D29374
To: weisi, winterz, davidedmundson
Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29371
To: dvratil, dfaure, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,
davidedmundson abandoned this revision.
davidedmundson added a comment.
All these problems go away with KWaylandServer \o/
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D28498
To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n
davidedmundson added a comment.
> Hmm, I can't build kwin
Hit the same thing, we've since fixed that (patch in kwayland-server)
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29278
To: apol, #kwin, #plasma, #frameworks, davidedmundson
Cc: zzag, kw
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29278
To: apol, #kwin, #plasma, #frameworks, davidedmundson
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev,
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in KeySequenceItem.qml:57
> Why is it the worst? It keeps us from having to hardcode magic numbers.
See task.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D29292
To: davidedmundson, #plasma,
davidedmundson added inline comments.
INLINE COMMENTS
> cblack wrote in KeySequenceItem.qml:57
> Are we able to use some form of units? Hardcoding this seems wrong.
> Can we use the non-attached version here please since it's not likely
It's the worst!
> Are we able to use some form of units?
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This implicitly fixes a bug where space is used in the shortcut i
davidedmundson added inline comments.
INLINE COMMENTS
> zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:21
> You've probably meant Q_DECL_HIDDEN, right?
>
> On an unrelated note: there are valid arguments against nested private
> classes so it would be really nice if we revisit this topi
davidedmundson added a comment.
Let's wait for the new kwaylandserver repo before pushing.
But ++, looks good.
INLINE COMMENTS
> keyboard_shortcuts_inhibit_interface.cpp:21
> +
> +class KeyboardShortcutsInhibitorInterface::Private : public
> QtWaylandServer::zwp_keyboard_shortcuts_inhib
That is what I imagined.
The protocols section contains some things we can strip down.
We shouldn't host anything that's in wayland-protocols like text-input.
Also I think there's some dead things like plasma-effects.
But we can do that sort of thing anytime before the first release.
David
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
introduce-mapped-signal
REVISION DETAIL
https://phabricator.kde.org/D29256
To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham
On Tue, 28 Apr 2020, 07:24 Vlad Zahorodnii, wrote:
> On 4/27/20 4:12 PM, David Edmundson wrote:
> > I don't think we want to remove client or server tests on this one. As
> > the client tests covered the server side too
>
> Hmm, does this mean we are going to keep both
On Mon, Apr 27, 2020 at 2:12 PM David Edmundson
wrote:
>
>
> On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote:
>
>> Hi,
>> As discussed in the meeting last week, I've been looking into the split.
>>
>> Here's what I was thinking of, please tell me i
On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote:
> Hi,
> As discussed in the meeting last week, I've been looking into the split.
>
> Here's what I was thinking of, please tell me if there's something
> massively important I'm missing.
>
> The idea would be to start working on it after kwayland a
davidedmundson added inline comments.
INLINE COMMENTS
> screencast.xml:46
> +
> +
> +
add type = "destructor"
so that clients calling this release the resource
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D28882
To: apol, #kwin, jgrulich, d
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c557cdba3a73: Add wrapper for wl_global_remove (authored
by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28883?vs=80279&id=81103
REVISION DETAI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28470
To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks
Cc: mart, davidre, cblack,
We had a meeting. It resulted in some final action decisions.
These will affect the kwayland folder in frameworks.
The meeting was attended by: Kevin Ottens, Vlad Zahorodnii, Aleix Pol,
Myself, Benjamin Port who all approved the plan.
*Protocols:*
We make a new repo. It will contain just protoco
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
In future, it might be faster to put up just the interface xml for review
first.
--
In terms of wayland protocols this is non-standard.
All clien
davidedmundson added a dependent revision: D28305: Systemd Startup.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28355
To: davidedmundson
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n,
cblack, bencreasy, michaelh, ngraham, bru
davidedmundson added a dependent revision: D28305: Systemd Startup.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29034
To: broulik, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,
bruns
davidedmundson added a dependent revision: D28305: Systemd Startup.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D29035
To: broulik, #plasma, #frameworks
Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, mkulin
davidedmundson added a dependent revision: D28305: Systemd Startup.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D29051
To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencrea
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Yeah, size is in logical pixels. Multiplying doesn't make sense.
I'm sure more high DPI bugs are caused by clients trying to be clever.
REPOSITORY
R242 Plasma Framewo
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29054
To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
davidedmundson added inline comments.
INLINE COMMENTS
> plasma-window-management.xml:77
> +
> +This event will be sent when stacking order changed
> +
we also need to send it on bind
> plasma-window-management.xml:83
>
>
>
Can we change them all at once.
> plas
davidedmundson added a comment.
I'm not sure why we set KillMode
Though I'm favour of merging then tweaking some of this, the service files
won't do anything till someone pulls them in.
Don't push before relevant ECM and relevant p-w patch is in
INLINE COMMENTS
> plasma-kwin_x11.se
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28499
To: broulik, #frameworks, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
davidedmundson added a comment.
We also need to change the installed DBus service file so that we link the
two in the unlikely event that kded is called
I need to either update the dbus generator macro, or we skip the macro and
put the service file in here, the old way
INLINE COMMENTS
On Thu, Apr 16, 2020 at 10:26 PM David Edmundson
wrote:
>
> > Given Doodle's take forever and everyone's probably quarantined
> > anyway, I propose we do it just after the Monday Plasma meeting. If
> > someone is eager to share an opinion and can't make tha
> > The slight twist on that which we need to be wary of is that client
> > code will return shared objects if you request a
> > KWaylandClient::PlasmaShellSurface::get(window())
> > for the same window from two places you'll get the same PlasmaShell
> > instance returned - and therefore the same w
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Assuming VDG are happy, go for it.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D27540
To: ervin, ngraham, davidedmundson, meven, crossi,
davidedmundson accepted this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D27840
To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham,
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27841
To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham,
#frameworks, #plasma, #vdg
Cc: plasma-devel, Orag
davidedmundson added a comment.
> This seems super complicated.
It is :D
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D28892
To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1b1412943b6b: [autotests] Optimistic attempt to fix
RemoteAccessTest reilability (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28892
davidedmundson added a comment.
> @davidedmundson did some bootchart that showed startup is actually faster
without this
It was probably just noise as it wasn't a full average of N tests, just 2
clean boots. However ksplash removed 100ms earlier. I can attach if needed.
As for the
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28900
To: apol, #build_system, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, kde-buildsyste
On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens wrote:
>
> Hello,
>
> On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote:
> > Here is a list of active uses of the KWayland::Client API.
> >
> > frameworks
> > plasma-framework (for window position
> Given Doodle's take forever and everyone's probably quarantined
> anyway, I propose we do it just after the Monday Plasma meeting. If
> someone is eager to share an opinion and can't make that, message here
> and we'll choose something more formally.
That didn't really work out. Doodle it is!
h
davidedmundson updated this revision to Diff 80312.
davidedmundson added a comment.
update
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28892?vs=80311&id=80312
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28892
AFFECTED FILES
autot
davidedmundson updated this revision to Diff 80311.
davidedmundson added a comment.
spelling
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28892?vs=80310&id=80311
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28892
AFFECTED FILES
aut
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
In this test we are waiting on 4 events. 2 things via 2 threads. It
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Removes the Global from the registry, but does not delete the und
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> [14:12] DavidRedondo1: my understanding is that a system might ship
"konsole opens with control+t". The UI allows you to remove that. This
would remove the entry in k
davidedmundson added a comment.
kglobalshortcutseditor.cpp
needs updating to match
I think you're right with your reasoning about NoDisplay, but we do want
something to be able to mask system files. From the spec should we be checking
Hidden= ?
REPOSITORY
R268 KGlobalAccel
REVISION
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
We copy udisks xml already. I don't think it ends up any better. Otherwise we
have a compile time dep on a runtime plugin, which inevitably means we need to
make i
davidedmundson added a comment.
Note there's a unit test for IconItem worth running if you haven't already.
The refactor in general makes sense - it's a lot cleaner.
Though I'm not sure what our super long term KF6 plan for IconItem is, it'll
definitely be changing quite a bit.
REPOSI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
release (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28697
To: davidre, broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast0
1 - 100 of 2832 matches
Mail list logo
