D28470: WIP: IconItem: Refactor source handling for different types

kmaterka added a comment. Do you think it is a good direction? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson Cc: kde-frameworks-devel, #plasma, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28470: WIP: IconItem: Refactor source handling for different types

kmaterka created this revision. kmaterka added reviewers: Plasma, broulik, apol, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY There are 3 possible strategies: QIcon, QImage and SV

D28466: Added Page element

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but make sure @davidedmundson or another #plasma person agrees. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETA

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. In D28444#639020 , @cblack wrote: > CMake needs to know what files Cargo wants to build in order to invoke it only when Rust files change. There's no reason to invoke Cargo every time `make` is ran when CMake has the

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638988 , @IlyaBizyaev wrote: > In D28444#638877 , @cblack wrote: > > > CMake needs to know when the Rust source has changed so it can rebuild it > > > Changes

D28466: Added Page element

ngraham added a comment. In D28466#639018 , @niccolove wrote: > In D28466#639011 , @ngraham wrote: > > > Could you add some explanation regarding what this is for? Ideally, both in the phab patch a

D28466: Added Page element

niccolove added a comment. In D28466#639011 , @ngraham wrote: > Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs. > > Also shouldn't this be in PlasmaExtras? I'll

D28466: Added Page element

ngraham added a comment. Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs. Also shouldn't this be in PlasmaExtras? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To

D28457: kdirwatch: fix a recently introduced crash

bruns accepted this revision. bruns added a comment. LGTM, thanks REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28457 To: meven, bruns, #frameworks, iasensio Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove updated this revision to Diff 79004. niccolove added a comment. Used correct year and implicitWidth/Height code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28466?vs=78994&id=79004 BRANCH master REVISION DETAIL https://p

D28466: Added Page element

davidedmundson added inline comments. INLINE COMMENTS > Page.qml:2 > +/* > + * Copyright 2016 Niccolò Venerandi > + * when did you add it? > Page.qml:24 > +T.Page { > +implicitWidth: Math.max(background ? background.implicitWidth : 0, > +(contentItem ? content

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. In D28388#638986 , @meven wrote: > In D28388#638722 , @ahmadsamir wrote: > > > ... > > > Open a diff to have a focused conversation. Good point. Thanks. :)

D28457: kdirwatch: fix a recently introduced crash

meven updated this revision to Diff 79002. meven marked 2 inline comments as done. meven added a comment. Add entryAdded = false to make things explicit and prevent warnings REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28457?vs=78958&id=79002 BRANCH

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. In D28444#638877 , @cblack wrote: > CMake needs to know when the Rust source has changed so it can rebuild it Changes to Rust code need to be tracked by Cargo, not by CMake REPOSITORY R240 Extra CMake Module

D28457: kdirwatch: fix a recently introduced crash

meven edited the summary of this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28457 To: meven, bruns, #frameworks, iasensio Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ndavis added a comment. Somehow I missed the notification that this was updated. Thanks for the horizontal alignment. Could you also add a left margin to the column of reset buttons? It should be the same as the spacing between the labels and the controls, which is `Kirigami.Units.smallS

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

meven added a comment. In D28388#638722 , @ahmadsamir wrote: > ... Open a diff to have a focused conversation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28388 To: dfaure, trmdi, ahmadsamir, meven Cc: kde-fram

D28466: Added Page element

niccolove added a dependent revision: D28467: Converted to Page with a PlasmodHeading in the heading. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, br

D28466: Added Page element

niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Page element was missing. I added it. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAI

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

davidedmundson added a comment. What do we want to happen for released code that gets a bugfix update? INLINE COMMENTS > kconfigdialogmanager.cpp:609 > +const auto defaultValue = [item] { > +item->swapDefault(); > +const auto value = item->property(); Why not item->readDe

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638540 , @IlyaBizyaev wrote: > In D28444#638430 , @cblack wrote: > > > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with th

D28271: [KFontChooser] More code cleanup

ahmadsamir updated this revision to Diff 78986. ahmadsamir added a comment. Move family checkbox and listview code next to each other REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28271?vs=78983&id=78986 BRANCH l-kfontchooser-3 (branched from mas

D28463: do not install testengine

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D28463 To: sitter, mart, apol Cc: broulik, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngr

D28463: do not install testengine

broulik added a comment. It's not used by any tests either REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28463 To: sitter, mart Cc: broulik, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28463: do not install testengine

apol added a comment. How is it going to be tested then? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28463 To: sitter, mart Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28271: [KFontChooser] More code cleanup

ahmadsamir updated this revision to Diff 78983. ahmadsamir added a comment. - Simplify connect() calls - Move the connect() calls of the various checkboxes, in ShowDifferences mode, after the widgets they enable/disable have been created REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST

D28271: [KFontChooser] More code cleanup

ahmadsamir planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > bport wrote in kfontchooser.cpp:347 > This comment is still valid ? Yes, that's after setting the font family/style/size list views and the size DoubleSpinBox. REPOSITORY R236 KWidgetsAddons REV

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 78979. ahmadsamir added a comment. Don't use a lambda in connetc() where it's not needed REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28274?vs=78441&id=78979 BRANCH l-monospace-checkbox REVISION DETAIL

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a comment. Ping? Not super critical, i guess, but it just feels sad to have things pending for weeks... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc: davidedmunds

D28460: Add KCModuleStateProbe as base class for plugin

broulik added inline comments. INLINE COMMENTS > kcmodulestateprobe.h:21 > + > +#ifndef KCMODULEDEFAULT_H > +#define KCMODULEDEFAULT_H `KCMODULESTATEPROBE_H` > kcmodulestateprobe.h:25 > +#include > +#include > +#include Forward-declare > kcmodulestateprobe.h:39 > +virtual bool isDefaul

D28457: kdirwatch: fix a recently introduced crash

bruns added inline comments. INLINE COMMENTS > kdirwatch.cpp:956 > #else > -case KDirWatch::FAM: Q_UNREACHABLE(); break; > +case KDirWatch::FAM: break; > #endif Can you change that to `case KDirWatch::FAM: entryAdded = false; break` to make it a little bit more explicit? > kdirwatch.

D28463: do not install testengine

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY by default users have to opt out of BUILD_TESTING meaning everyone would by default build

D28460: Add KCModuleStateProbe as base class for plugin

broulik added inline comments. INLINE COMMENTS > kcmoduleloader.cpp:165 > + > +if (!mod.library().isEmpty()) { > +QString error; Use an early return here > kcmoduleloader.cpp:176 > +if (factory) { > +auto p = factory->create(nullptr, args2); > +if (p)

D28460: Add KCModuleStateProbe as base class for plugin

bport added a dependent revision: D28461: In sidebar mode show if a module is in default state or not. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28460: Add KCModuleStateProbe as base class for plugin

bport created this revision. bport added reviewers: Plasma, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY This class will allow to get state of a module without loading the UI. REPOSITORY R

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. In D28388#637419 , @dfaure wrote: > In D28388#637417 , @ahmadsamir wrote: > > > (Now the other issue, "DEVICE" (from the kproperties patch) is always "8", whether I use ~

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove added a subscriber: manueljlin. niccolove added a comment. Generally speaking, I'd still like for all applets to have a row of plasmoidheading on the bottom of system tray's own because having just system tray plasmoidheading, especially with the new small font, does not feel "enou

D28457: kdirwatch: fix a recently introduced crash

iasensio accepted this revision. iasensio added a comment. This revision is now accepted and ready to land. Thanks! It fixes `BUG: 419428` REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28457 To: meven, bruns, #frameworks, iasensio Cc: kde-frame

D28349: Fix Warnings

iasensio added a comment. In D28349#638395 , @bruns wrote: > @iasensio - are you using NFS? It's a NTFS partition using `fuseblk`, but anyway D28457 fixes the crash REPOSITORY R244 KCoreAddons REVI

D28457: kdirwatch: fix a recently introduced crash

meven created this revision. meven added reviewers: bruns, Frameworks, iasensio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevent a crash when browsing nfs without FAM installed introduced in D2

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfontchooser.cpp:347 > > // Completed the font attributes grid > This comment is still valid ? > kfontchooser.cpp:381 > +if (flags & ShowDifferenc

D28349: Fix Warnings

meven added inline comments. INLINE COMMENTS > bruns wrote in kdirwatch.cpp:946 > m_nfsPreferredMethod defaults to `KDirWatch::FAM`, i.e. it will crash below > now on NFS when FAM is disabled. So either change the default, or add a Q_FALLTHROUH() ? REPOSITORY R244 KCoreAddons REVISION DETAI