bruns added inline comments. INLINE COMMENTS
> kdirwatch.cpp:956 > #else > - case KDirWatch::FAM: Q_UNREACHABLE(); break; > + case KDirWatch::FAM: break; > #endif Can you change that to `case KDirWatch::FAM: entryAdded = false; break` to make it a little bit more explicit? > kdirwatch.cpp:959 > #if HAVE_SYS_INOTIFY_H > case KDirWatch::INotify: entryAdded = useINotify(e); break; > #endif bonus points for adding #else case KDirWatch::INotify: entryAdded = false; break; here (otherwise the switch may be incomplete), dito for QFSWatch below. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28457 To: meven, bruns, #frameworks, iasensio Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
