broulik added inline comments.
INLINE COMMENTS
> kcmoduleloader.cpp:165
> +
> + if (!mod.library().isEmpty()) {
> + QString error;
Use an early return here
> kcmoduleloader.cpp:176
> + if (factory) {
> + auto p = factory->create<KCModuleStateProbe>(nullptr, args2);
> + if (p) {
This looks like it leaks
> kcmoduleloader.cpp:182
> +
> + auto p = mod.service()->createInstance<KCModuleStateProbe>(nullptr,
> args2, &error);
> + if (p) {
Error can be `nullptr`. Either print a warning or remove it
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
