D26359: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: Plasma. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY With QRegularExpression, a "-" character inside a character class, [], indicates a range; one way to match a literal "-" ins

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a comment. Not too sure if it helps bug https://bugs.kde.org/show_bug.cgi?id=414482 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPe

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a reviewer: ngraham. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh

D26358: KIO/SMB convert kio protocol declaration to json format

meven created this revision. meven added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.

D26358: KIO/SMB convert kio protocol declaration to json format

meven updated this revision to Diff 72596. meven added a comment. clean REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72595&id=72596 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26358 AFFECTED FILES smb/CMakeLists.txt s

D26326: Add application/x-audacity-project icon

broulik added a comment. The icon is the midi icon which uses those colors. Feel Fred to commandeer this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis, ngraham Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

mlaurent added a reviewer: apol. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D26301 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

mlaurent updated this revision to Diff 72594. mlaurent added a comment. Merge "\n" + use '\n' REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26301?vs=72417&id=72594 BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.

D26302: Port endl to "\n" + flush at the end

mlaurent added a reviewer: apol. REPOSITORY R298 KDesignerPlugin REVISION DETAIL https://phabricator.kde.org/D26302 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

mlaurent updated this revision to Diff 72593. mlaurent added a comment. Merge \n and use '\n' REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26302?vs=72418&id=72593 BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabric

D26318: Port endl to "\n" flush at the end + use const'ref in loop

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6ed68fd17385: Port endl to "\n" flush at the end + use const'ref in loop (authored by mlaurent). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26318?vs=72513&

D26299: endl is namespaced in qt5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R280:99009fc60051: endl is namespaced in qt5.15 (authored by mlaurent). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26299?vs=72510&id=72591 REVISION DETAIL https://

D25673: Deprecate KServiceTypeProfile

nicolasfella updated this revision to Diff 72590. nicolasfella added a comment. - Update update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25673?vs=72589&id=72590 BRANCH arcpatch-D25673 REVISION DETAIL https://phabricator.kde.org/D25673 AFFECTED

D25673: Deprecate KServiceTypeProfile

nicolasfella updated this revision to Diff 72589. nicolasfella added a comment. - Update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25673?vs=70708&id=72589 BRANCH arcpatch-D25673 REVISION DETAIL https://phabricator.kde.org/D25673 AFFECTED FILES

D25673: Deprecate KServiceTypeProfile

nicolasfella marked an inline comment as done. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25673 To: nicolasfella, #frameworks Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

cblack added a comment. The foreground's colour contrast against the base of the colour icon should be higher IMO. (I have to squint to make out the emblem, which kinda defeats the purpose of an icon: making a filetype easier to see.) Plus, dark mimetype icons almost never use a darker s

D26326: Add application/x-audacity-project icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis, ngraham Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 250 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/250/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 01 Jan 2020 23:59:33 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fai

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72584. feverfew added a comment. Fix introduction of BIC method REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72181&id=72584 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191

D26148: Add truncation support to FileJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:578fbf45297b: Add truncation support to FileJob (authored by feverfew). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=72538&id=72585 REVISION DETAIL https:

D26299: endl is namespaced in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH compile_against_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26299 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26318: Port endl to "\n" flush at the end + use const'ref in loop

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26318 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

kossebau added a comment. @mlaurent Hm, is there a chance ABI got broken by that respective code in Qt 5.15 when it comes to the non-Qt-namespaced variants of the methods? Unless I misread, those deprecated ones are now in the QTextStreamFunctions namespace. And which might be source compati

D26148: Add truncation support to FileJob

feverfew added a comment. In D26148#585958 , @dfaure wrote: > In D26148#585944 , @ngraham wrote: > > > Thanks @dfaure! Would you be able to also review D26191 ?

D25443: [chmodjob] Port away from QLinkedList

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Code looks good, just the comment needs a fix. [Too bad std::stack doesn't seem to have a reserve() method.] INLINE COMMENTS > chmodjob.cpp:188 ><

D26331: Removed reading description from desktop files

ngraham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

ngraham added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25443: [chmodjob] Port away from QLinkedList

nicolasfella added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26285 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bruns

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26339 To: ahmadsamir, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

romangg updated this revision to Diff 72576. romangg added a comment. - Cleanup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26171?vs=72575&id=72576 BRANCH viewporter REVISION DETAIL https://phabricator.kde.org/D26171 AFFECTED FILES autotests/cl

D26171: Implement wp_viewporter

romangg updated this revision to Diff 72575. romangg marked 6 inline comments as done. romangg added a comment. - Check source rectangle on related changes, buffer rename. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26171?vs=72029&id=72575 BRANCH vie

D26292: [KSambaShare] Port QRegExp to QRegularExpression

dfaure added a comment. Urgh, my apologies. I must have read a v1-v2 diff then. Oh well, no big deal either way. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26292 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 249 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/249/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 01 Jan 2020 19:20:26 + Build duration: 6 min 56 sec and counting JUnit Tests Name: projectro

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R249:f9b932d254c4: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26285?vs=725

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26292#586025 , @dfaure wrote: > Now I'm completely confused. Did you just argue *against* your own change? > > You seem to say the old name was better... The original code, before I put my paws on it, us

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

dfaure accepted this revision. REPOSITORY R249 KI18n BRANCH l-finalizeVisualText (branched from master) REVISION DETAIL https://phabricator.kde.org/D26285 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bru

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c930030308cc: [KFileWidgets] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72564&id=72568 REVISI

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72567. ahmadsamir added a comment. Ternary that doesn't return a value is weird, better avoid. "Grammar fixes" in comments add noise to the diff, be kind to reviewers. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 248 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/248/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 01 Jan 2020 19:05:52 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fai

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26339 To: ahmadsamir, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D26292: [KSambaShare] Port QRegExp to QRegularExpression

dfaure added a comment. Now I'm completely confused. Did you just argue *against* your own change? You seem to say the old name was better... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26292 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72564. ahmadsamir added a comment. Declare QRegularExpression before for-loop REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72527&id=72564 BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 247 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/247/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 01 Jan 2020 18:48:15 + Build duration: 17 min and counting JUnit Tests Name: projectroot Fai

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:411df4148937: [KURISearchFilterEngine] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26332?vs=72528&id=725

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26332#585913 , @dfaure wrote: > Tested with http://www.davidfaure.fr/2020/qregularexpr_replace.cpp This is also covered by kurifiltertest. REPOSITORY R241 KIO BRANCH l-ikws (branched from master) REVI

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in ksambashare.cpp:259 > badPattern was a bad name? ;-) !notToMatchRx.match() -> "not notToMatchRx" double negative, slightly weird/heavy on the ear. !badPattern.match() -> "not badPattern" -> valid share name; there's method to

D26292: [KSambaShare] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4965c4f9e2a2: [KSambaShare] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26292?vs=72543&id=72559 REVISIO

D26148: Add truncation support to FileJob

dfaure added a comment. In D26148#585944 , @ngraham wrote: > Thanks @dfaure! Would you be able to also review D26191 ? Yes, once it has been ported to virtual_hook as well. REPOSITORY R241 KIO BRANC

D26148: Add truncation support to FileJob

ngraham added a comment. Thanks @dfaure! Would you be able to also review D26191 ? REPOSITORY R241 KIO BRANCH arcpatch-D26148 REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure,

D26326: Add application/x-audacity-project icon

ngraham accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis, ngraham Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 261 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/261/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 01 Jan 2020 18:08:37 + Build duration: 13 min and counting BUILD ARTIFACTS acc/KF5KIO-5.66.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 246 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/246/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 01 Jan 2020 18:08:37 + Build duration: 9 min 9 sec and counting JUnit Tests Name: projectroo

D26292: [KSambaShare] Port QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ksambashare.cpp:259 > // Samba forbidden chars > -const QRegExp notToMatchRx(QStringLiteral("[%<>*\?|/\\+=;:\",]")); > -return (notToMatchRx.indexIn(name) =

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I wonder if others agree that "a ? b() : c()" is bad form for void b() and void c(), compared to an if(), or if it's just me. INLINE COMMENTS > kuitmarkup.cpp:1582 > +// un

D26006: Deprecate KPixmapProvider

This revision was automatically updated to reflect the committed changes. Closed by commit R284:7fd8df18c3e4: Deprecate KPixmapProvider (authored by nicolasfella). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26006?vs=71557&id=72554 REVISION DETAIL ht

D25702: Deprecate KUrlPixmapProvider

This revision was automatically updated to reflect the committed changes. Closed by commit R241:00e8034f0e9a: Deprecate KUrlPixmapProvider (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25702?vs=72537&id=72553 REVISION DETAIL https:/

D26148: Add truncation support to FileJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D26148 REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_

D25702: Deprecate KUrlPixmapProvider

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25702_1 REVISION DETAIL https://phabricator.kde.org/D25702 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

dfaure added a comment. I don't think a code generator needs to flush() many times along the way anyway. \n actually sounds more efficient. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Tested with http://www.davidfaure.fr/2020/qregularexpr_replace.cpp REPOSITORY R241 KIO BRANCH l-ikws (branched from master) REVISION DETAIL https://phabricator.kde.org/D26332 To: ah

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

mludwig updated this revision to Diff 72552. mludwig added a comment. Small fix to the documentation. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26346?vs=72551&id=72552 REVISION DETAIL https://phabricator.kde.org/D26346 AFFECTED FILES src/core/gues

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

mludwig created this revision. mludwig added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mludwig requested review of this revision. REVISION SUMMARY The documentation states that "Default is returning best guess without caring abo

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kfilewidget.cpp:2458 > Declaring rx before the for-loop isn't more efficient? then inside the > for-loop it's the same QRegularExpression object and setPattern() is called. Hmm OK this isn't like QString, reusing rx saves alloc

D24431: Restore cursor thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R320:55d370392efa: Restore cursor thumbnailer (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24431?vs=72476&id=72548 REVISION DETAIL https:/

D24431: Restore cursor thumbnailer

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham, davidedmundson Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasens

D26342: Allow overriding to disable auto language detection

mludwig added a comment. I'd support such a change for the BackgroundChecker as well. KTextEditor needs a way to do its own language detection or override the detected language. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks Cc: mludw

D26171: Implement wp_viewporter

davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in surface_interface.cpp:882 > How I read the spec: the source rectangle is always specified in coordinates > after scale and transform. [1] > > `SurfaceInterface::size()` returns the scaled and transformed (not yet) > buffe

D25495: Fix Sonnet autodetect failing on Indian langs

waqar updated this revision to Diff 72545. waqar added a comment. Apply requested changes REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70291&id=72545 BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. Hi, First of all thanks for reviewing. > I'd suggest to move your changes to GuessLanguage::identify(const QString &text, const QStringList &suggestionsListIn) after the call to d->identify(text, d->findRuns(text)); Okay. I will do that, but I will have to m

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72543. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments (from other reviews) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26292?vs=72386&id=72543 BRANCH l-qregularexpressi

D26342: Allow overriding to disable auto language detection

sdepiets edited the summary of this revision. sdepiets added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

sdepiets created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sdepiets requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D26342 AFFECTED FILES src/ui/highlighter.cpp

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:1342 > Duplication :-) > > Dangerous, if the actual char* is modified one day. Personally, I needed to see the actual regex spelled out like that to understand the rest of the code in this function, this: QLa

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72539. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26285?vs=72363&id=72539 BRANCH l-finalizeVisualText (branched from m

D26148: Add truncation support to FileJob

feverfew updated this revision to Diff 72538. feverfew added a comment. Fix introduction of BIC method REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=72180&id=72538 BRANCH arcpatch-D26148 REVISION DETAIL https://phabricator.kde.org/D26148 AFFECT

D25495: Fix Sonnet autodetect failing on Indian langs

mludwig added a comment. You are right that in GuessLanguage::identify(const QString &text, const QStringList &suggestionsListIn), if a language without trigrams is not present in 'suggestionsListIn', it will never be 'guessed'. I'd suggest to move your changes to GuessLanguage::identify

D25702: Deprecate KUrlPixmapProvider

nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25702 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

nicolasfella updated this revision to Diff 72537. nicolasfella added a comment. - fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25702?vs=72414&id=72537 BRANCH arcpatch-D25702_1 REVISION DETAIL https://phabricator.kde.org/D25702 AFFECTED FILES src/

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

kossebau added a comment. Ah, I looked at the "dev" branch only and missed that it is possibly already pre-Qt6, no longer base for any future Qt5 branches, right? Indeed things look differently in the 5.15 branch, where the old variant is tagged deprecated, I now see. Have to tell that

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

This revision was automatically updated to reflect the committed changes. Closed by commit R238:48b3c03fc710: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when… (authored by mlaurent). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D26118: Port QRegExp to QRegularExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:b2975d8e630c: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R283 KAuth CHANGES SINCE LAST

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72528. ahmadsamir added a comment. Address comments: Search offset can't be +=, since the position is moves with capturedStart(). More compact code, always declare where used (don't micro-optimise?) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfilewidget.cpp:2458 > declare where used Declaring rx before the for-loop isn't more efficient? then inside the for-loop it's the same QRegularExpression object and setPattern() is called. REPOSITORY R241 KIO REVISION DETA

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72527. ahmadsamir added a comment. Use const REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72522&id=72527 BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D26326: Add application/x-audacity-project icon

broulik updated this revision to Diff 72526. broulik added a comment. - Optimize - Copy to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72473&id=72526 REVISION DETAIL https://phabricator.kde.org/D26326 AFFECTED FILES icon

D26207: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R306:2b4279cd9dd2: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26207?vs=72134&id=72524 REVISION DETAIL

D26193: KNotifyConfig: port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R305:99b0074734e4: KNotifyConfig: port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26193?vs=72107&id=725

D26339: [KFileWidgets] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72522. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26339?vs=72517&id=72522 BRANCH l-kfilewidgets-regexp (branched from master) REVISION DETAIL https://phabricator.kde

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure, aacid Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 245 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/245/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 01 Jan 2020 10:47:13 + Build duration: 9 min 38 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 260 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/260/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 01 Jan 2020 10:47:12 + Build duration: 7 min 37 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.66.0

D26155: Add RPM support to Krarc

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a6d068dee88a: [KUrlNavigator] Add RPM support to krarc: (authored by gengisdave). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26155?vs=72001&id=72519#toc REPOSITORY R241 KIO CHANGES SINC

D26321: Expose show-line-count in the ConfigInterface

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:3026a9caa868: Add "line-count" property to the ConfigInterface (authored by mludwig). CHANGED PRIOR TO COMMIT https:/

D25702: Deprecate KUrlPixmapProvider

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kurlpixmapprovider.cpp:26 > > +#if KIOWIDGETS_ENABLE_DEPRECATED_SINCE(5, 66) > + Ah, no, s/ENABLE_/BUILD_/ in cpp files REPOSITORY R241 KIO REVISION DET

D25702: Deprecate KUrlPixmapProvider

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH arcpatch-D25702 REVISION DETAIL https://phabricator.kde.org/D25702 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2

D26193: KNotifyConfig: port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D26193 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26207: Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26207 To: ahmadsamir, #frameworks, dfaure, mlaurent, apol Cc: kde-frameworks-devel, LeGast

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kuriikwsfiltereng.cpp:144 > +int start = 0; > +QString str; > +while (match.hasMatch()) { declare where first used (2 lines down) > k

D26118: Port QRegExp to QRegularExpression

dfaure accepted this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   >