ahmadsamir updated this revision to Diff 72567. ahmadsamir added a comment.
Ternary that doesn't return a value is weird, better avoid. "Grammar fixes" in comments add noise to the diff, be kind to reviewers. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26285?vs=72539&id=72567 BRANCH l-finalizeVisualText (branched from master) REVISION DETAIL https://phabricator.kde.org/D26285 AFFECTED FILES src/kuitmarkup.cpp To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bruns