davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in surface_interface.cpp:882
> How I read the spec: the source rectangle is always specified in coordinates 
> after scale and transform. [1]
> 
> `SurfaceInterface::size()` returns the scaled and transformed (not yet) 
> buffer size so since viewporter coordinates are to this base we can just 
> directly return them.
> 
> [1] 
> https://gitlab.freedesktop.org/wayland/wayland-protocols/blob/master/stable/viewporter/viewporter.xml#L103

Yeah, on re-reading I think your intepretation is right. Leave your stuff as-is.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26171

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to