D20697: Review IconBorder

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I like the visual change, let's give it a try. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann Cc: dhauman

D20700: Add "edit-remove" icon

GB_2 added a comment. Oops, forgot that `paint-none` already exists, which looks like this. I will just make a symlink then. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20702: KTar: Protect against negative longlink sizes

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Some of the negative values can cause uninitialize memory reads further down the code oss-fuzz #14381 REPOSITORY R2

D20700: Add "edit-remove" icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add an alternative to `list-remove`, which needs to be next to `list-add` for context and `edit-d

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

yurikoles added a comment. How about issuing a minor release? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20691 To: shubham, meven Cc: yurikoles, elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

elvisangelaccio accepted this revision. REPOSITORY R318 Dolphin BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20668 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, elvisangelaccio Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebar

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

elvisangelaccio accepted this revision. REPOSITORY R824 Baloo Widgets BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich, elvisangelaccio Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippic

D20525: [InformationPanel] Use the new inline configuration mode

elvisangelaccio added inline comments. INLINE COMMENTS > informationpanelcontent.cpp:113-114 > +m_configureLabel = new QLabel(i18nc("@label::textbox", > + "Select which data should " > + "be shown:"), this); > +

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 20 Apr 2019 14:23:07 + Build duration: 1 min 14 sec and counting JUnit Tests Name: projectr

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

This revision was automatically updated to reflect the committed changes. Closed by commit R245:b63c2a236faf: Fix no member named 'setTime_t' in 'QDateTime' error while building (authored by shubham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20691?vs=56627

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

elvisangelaccio resigned from this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH error REVISION DETAIL https://phabricator.kde.org/D20691 To: shubham, meven Cc: elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

shubham updated this revision to Diff 56627. shubham added a comment. Fix unintentional mode change REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20691?vs=56609&id=56627 BRANCH error REVISION DETAIL https://phabricator.kde.org/D20691 AFFECTED FILES

D20697: Review IconBorder

loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demski

D20697: Review IconBorder

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The only two included changes noticeable by the user are:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Apr 2019 11:15:59 + Build duration: 36 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllogs

D20565: Ensure not to fold the end marker

loh.tar abandoned this revision. loh.tar added a comment. Patch is part of D20606 > And happy Easter ;=) Thank you! :-) REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel,

D20264: Add test for "Auto Reload Document" option

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f5f715ea1441: Add test for "Auto Reload Document" option (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20264?vs=55576&id=56623#toc REPOSITORY R39 KTextEditor CHANGES

D20606: Add action to toggle folding of child ranges

This revision was automatically updated to reflect the committed changes. Closed by commit R39:5c83e29561e3: Add action to toggle folding of child ranges (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20606?vs=56527&id=56624#toc REPOSITORY R39 KTextEditor CHANGE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/94/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 20 Apr 2019 11:15:59 + Build duration: 8 min 23 sec and counting JUnit Tests Name: projectroo

D20695: Add more icon sizes for audio, configure, distribute

ndavis updated this revision to Diff 56622. ndavis added a comment. Fix 16-16-audio-volume-muted REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20695?vs=56621&id=56622 BRANCH add-new-size (branched from master) REVISION DETAIL https

D20695: Add more icon sizes for audio, configure, distribute

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

meven added a comment. In D20694#453296 , @dfaure wrote: > I fixed them ;-) Nice back to stable tests! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-framewor

D20695: Add more icon sizes for audio, configure, distribute

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

ndavis updated this revision to Diff 56621. ndavis added a comment. Add 16px audio icons REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20695?vs=56619&id=56621 BRANCH add-new-size (branched from master) REVISION DETAIL https://phabr

D20694: Use regular stat when resolving a symlink

dfaure added a comment. I fixed them ;-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Please revert the mode change to `Messages.sh` REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20691 To: shubham, meven, elvisangelaccio

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/83/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Apr 2019 10:32:24 + Build duration: 13 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 96 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/96/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 20 Apr 2019 10:32:24 + Build duration: 8 min 23 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.x

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/93/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 20 Apr 2019 10:32:24 + Build duration: 7 min 51 sec and counting JUnit Tests Name: projectroo

D20695: Add more icon sizes for audio, configure, distribute

ndavis planned changes to this revision. ndavis added a comment. Oops, looks like I need 16px audio icons as well for the volume/mute icons inside the opened audio widget. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #pl

D20694: Use regular stat when resolving a symlink

meven added a comment. Regressions are fixed : https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/95/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/ https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/95/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 20 Apr 2019 10:18:03 + Build duration: 8 min 37 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/82/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Apr 2019 10:18:03 + Build duration: 6 min 28 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/92/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 20 Apr 2019 10:18:03 + Build duration: 6 min 50 sec and counting JUnit Tests Name: projectroo

D20695: Add more icon sizes for audio, configure, distribute

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The tooltip for the audio system tray widget and panel edit mode had blurry versions

D20694: Use regular stat when resolving a symlink

meven added a comment. https://build.kde.org/view/OS - Windows/job/Frameworks/job/kio/job/kf5-qt5 SUSEQt5.10/95 Will confirm if this is fixed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-frameworks-devel, micha

D20694: Use regular stat when resolving a symlink

This revision was automatically updated to reflect the committed changes. Closed by commit R241:dfbc18403297: Use regular stat when resolving a symlink (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20694?vs=56616&id=56618 REVISION DETAIL h

D20694: Use regular stat when resolving a symlink

meven added a comment. In D20694#453252 , @bcooksley wrote: > The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months. I can't wait for gitlab migration. phabricator is quite n

D20694: Use regular stat when resolving a symlink

bcooksley added a comment. The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months. REPOSITORY R241 KIO BRANCH fix-test REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-fram

D20694: Use regular stat when resolving a symlink

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Glad that the unittest caught an actual bug for once :-) Yes we'd all love pre-merge CI checks, but that won't happen with phabricator. I hear rumours of a migration to gitlab at some p

D20694: Use regular stat when resolving a symlink

meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#453194 , @dfaure wrote: > I'm talking about jobtest and kdirmodeltest regressing exactly in build 87, which is where this commit landed. > If you click on history for a given test you can see that those aren't

D20694: Use regular stat when resolving a symlink

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Before f3b0f220a78d4e5a5b94b46e931779d755ac19ce

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/81/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Apr 2019 08:38:02 + Build duration: 38 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

D20692: Fix test KDirListerTest::testRenameItem

meven abandoned this revision. meven added a comment. I mixed up refreshItems and slotRefreshItems. My fix is nonsense REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20692 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/94/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 20 Apr 2019 08:38:02 + Build duration: 8 min 9 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.x

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/91/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 20 Apr 2019 08:38:02 + Build duration: 6 min 52 sec and counting JUnit Tests Name: projectroo

D20693: Remove pixelated border

leinir created this revision. leinir added reviewers: KNewStuff, ngraham, sitter. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In the before-times, drop shadows w

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

dfaure added a comment. I'm talking about jobtest and kdirmodeltest regressing exactly in build 87, which is where this commit landed. If you click on history for a given test you can see that those aren't sporadic failures: https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/ki

D20692: Fix test KDirListerTest::testRenameItem

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirlistertest.cpp:549 > + > +QSignalSpy spyRefreshItems(&m_dirLister, > SIGNAL(refreshItems2(QList>))); > QVERIFY(job->exec()); I don't see a signa

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. I don't why src/Messages.sh would need to be updated. But the fix seems fine to me. REPOSITORY R245 Solid BRANCH error REVISION DETAIL https://phabricator.kde.org/D20691 To: shubham

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#451170 , @dfaure wrote: > This change also introduced regressions in two unittests: jobtest and kdirmodeltest. I'll let you look into those :-) > > https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/j

D20692: Fix test KDirListerTest::testRenameItem

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The test was buggy to begin with : the wrong refreshedItems slot was used and wo