dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Glad that the unittest caught an actual bug for once :-) Yes we'd all love pre-merge CI checks, but that won't happen with phabricator. I hear rumours of a migration to gitlab at some point, which should surely help. REPOSITORY R241 KIO BRANCH fix-test REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns