meven added a comment.
In D20096#453194 <https://phabricator.kde.org/D20096#453194>, @dfaure wrote: > I'm talking about jobtest and kdirmodeltest regressing exactly in build 87, which is where this commit landed. > If you click on history for a given test you can see that those aren't sporadic failures: https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/ > and > https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/history/ > > The failures in kfileitemtest and kdirlistertest (note: model != lister) are unrelated, I'll look into those. Thank you for making this clear. The regression are associated with symlink resolution. I think I have identified the issue. Please see D20694 <https://phabricator.kde.org/D20694> and could we test this on CI. It makes me think that for some reviews, it would be good to test it on CI before merging. At my past place of work we used this extensively, it was quite helpful. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
