D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar added a comment. > Just to be on the safe side: Does this also work, if you have two views visible showing the same document, and then the message appears? As said, poor tested., but what needs to be taken care? Normally these messages works well, so no idea why now not. > D

D16579: Remove support for non-standard APE tag field names from the test files

ngraham added a comment. In D16579#428807 , @smithjd wrote: > In D16579#428790 , @ngraham wrote: > > > Two reviewers had open "Changes Requested" statuses on this patch when you committed it, and fr

D16579: Remove support for non-standard APE tag field names from the test files

smithjd added a comment. In D16579#428790 , @ngraham wrote: > Two reviewers had open "Changes Requested" statuses on this patch when you committed it, and from the latest comments, it's not clear that their concerns were addressed first. Can you

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 04:40:03 + Build duration: 9 min 7 sec and counting BUILD ARTIFACTS abi-compatibilit

D19621: ViewPrivate: Make deselection by arrow keys more handy

This revision was automatically updated to reflect the committed changes. Closed by commit R39:5c94789d28ea: ViewPrivate: Make deselection by arrow keys more handy (authored by loh.tar, committed by ngraham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D16579: Remove support for non-standard APE tag field names from the test files

ngraham added a comment. Two reviewers had open "Changes Requested" statuses on this patch when you committed it, and from the latest comments, it's not clear that their concerns were addressed first. Can you explain your thought process regarding why you felt it was appropriate to ignore yo

D18664: Baloo engine: treat every non-success code as a failure

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, ashap

D19667: Add Q_EMIT to emit signal call

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19667 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19668: Convert two old-style connects to new-style

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19668 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. If clazy says so... ¯\_(ツ)_/¯ REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D19666 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D19665: Add Q_OBJECT to KFilterDev

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D19665 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19646: Redesign KDE Connect and bluetooth config pages

apol added a comment. This adds a dependency to Kirigami. We are already tier2 so that's okay, but reflect it on CMake at least. INLINE COMMENTS > kdeconnectplugin_config.qml:41 > text: model.display > +icon: model.iconName > onClicked: root.device = deviceId Use i

D19668: Convert two old-style connects to new-style

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19668 AFFECTED FILES src/kdbusinterprocessloc

D19652: Add cross-compilation support for kpackagetool5

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Danke! REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19652 To: vkrause, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19667: Add Q_EMIT to emit signal call

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19667 AFFECTED FILES src/lib/plugin/kpluginfa

kde-frameworks-devel@kde.org

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY According to clazy since KConfigIniBackend::BufferFragment is very small it's faster to just copy it REPOSITORY R237 KCo

D19665: Add Q_OBJECT to KFilterDev

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's a good thing to have REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D19665

D18601: Rewrite taglib writer to use property interface

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:70 > > Taglib does not "handle this nicely". For APE and Xiph, it just accepts > > *any* unknown key and uses it verbatim, while for MP4 and ASF it rejects > > any unknown key. > > And so do APE::Tag::setItem an

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

dhaumann added a comment. Just to be on the safe side: Does this also work, if you have two views visible showing the same document, and then the message appears? Does it also work, if you have two main windows showing the same document (View > New Window)? INLINE COMMENTS > kateview.cpp:2

D19557: Update design to look more similar to kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R238:a67daca8199c: Update design to look more similar to kde.org (authored by ognarb). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53616&id=53617 REVISION

D19557: Update design to look more similar to kde.org

ognarb added a comment. In D19557#428634 , @ltoscano wrote: > Thank you! And sorry for the ping-pong. No problems ;) Thanks for the review. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557

D19557: Update design to look more similar to kde.org

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Thank you! And sorry for the ping-pong. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, lto

D19557: Update design to look more similar to kde.org

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update design to look more similar to kde.org

ognarb updated this revision to Diff 53616. ognarb added a comment. Don't change image link and remove kde.png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53603&id=53616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 A

D19557: Update design to look more similar to kde.org

ognarb retitled this revision from "Update css" to "Update design to look more similar to kde.org". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #docu

D19557: Update css

ltoscano added a comment. In D19557#428619 , @ognarb wrote: > In D19557#428618 , @ltoscano wrote: > > > In D19557#428617 , @ognarb wrote: > > > > > The

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

dhaumann added inline comments. INLINE COMMENTS > kossebau wrote in textcreator.cpp:169 > For the thumbnail the code is rendering on a paper-like canvas, which is > hard-coded as well (see lines above with `QColor ( 245, 245, 245 ); // > light-grey background`). To simulate a print-out, for wha

D19557: Update css

ognarb added a comment. In D19557#428618 , @ltoscano wrote: > In D19557#428617 , @ognarb wrote: > > > They use the old link for the image, also the jpg version instead of the png. I tested with new p

D19557: Update css

ltoscano added a comment. In any case, please change the commit message. When this is committed and rechecked in one year from now, the aspect of the linked website may not be relevant anymore and the images are not visible when you run git log. Please describe what the change is about. ht

D19557: Update css

ltoscano added a comment. In D19557#428617 , @ognarb wrote: > They use the old link for the image, also the jpg version instead of the png. I tested with new page and old page and the result is visually the same. But do the existing pages

D19557: Update css

ognarb added a comment. In D19557#428614 , @ltoscano wrote: > No, wait a minute. What happens with pages which are not regenerated? They use the old link for the image, also the jpg version instead of the png. I tested with new page and o

D19557: Update css

ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. No, wait a minute. What happens with pages which are not regenerated? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #docu

D19557: Update css

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscan

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in textcreator.cpp:169 > I saw this review request just now: Using a hardcoded theme is not a good > idea. I suggest to use a solution based on the background color. We have the > following in our example codeeditor: > > setThe

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 55 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/55/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 19:22:43 + Build duration: 23 min and counting JUnit Tests Name: projectroot Fail

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

dhaumann added inline comments. INLINE COMMENTS > textcreator.cpp:169 > + > syntaxHighlighter.setDefinition(m_highlightingRepository.definitionForFileName(path)); > +const auto highlightingTheme = > m_highlightingRepository.defaultTheme(KSyntaxHighlighting::Repository::Li

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar added a comment. > Ok with me. Thanks. > I still think that the unit test can be improved, like mixed rtl + ltr text, but ok :) That could be more difficult as you may expect. I think the current tests are OK, thisway has it to work always. The current behaviour in mixe

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/54/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 11:30:12 + Build duration: 1 day 7 hr and counting

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar updated this revision to Diff 53613. loh.tar added a comment. - Add actions to View menu - Contains some garbage lines - Still poor tested - One issue may/is that in case of multible views/windows the actions only get synced after an reload event :-/ CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 18:57:15 + Build duration: 6 min 55 sec and counting BUILD ARTIFACTS abi-comp

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.h:1086 > What about this: make this a QAction with setCheckable(true). Then, you could > reuse this action in the KTextEditor::Message. You can put this action then > into the menu as well. > > ...then again, this

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/42/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 18:57:15 + Build duration: 2 min 23 sec and counting BUILD ARTIFACTS abi-comp

D16579: Remove support for non-standard APE tag field names from the test files

smithjd retitled this revision from "Remove support for non-standard APE tag field names" to "Remove support for non-standard APE tag field names from the test files". smithjd edited the summary of this revision. smithjd edited the test plan for this revision. REPOSITORY R286 KFileMetaData RE

D16579: Remove support for non-standard APE tag field names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:4c5c4f5b91ab: Use 'ALBUM ARTIST' field name for APEv2 test files. (authored by smithjd). CHANGED PRIOR TO COMMIT htt

D19621: ViewPrivate: Make deselection by arrow keys more handy

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Ok with me. I still think that the unit test can be improved, like mixed rtl + ltr text, but ok :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D1962

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

dhaumann added inline comments. INLINE COMMENTS > katedocument.h:1086 > bool m_modOnHd = false; > +bool m_autoReloadMode = false; > +QTimer m_autoReloadThrottle; What about this: make this a QAction with setCheckable(true). Then, you could reuse this action in the KTextEditor::Mess

D19646: Redesign KDE Connect and bluetooth config pages

abetts added a comment. Could there be a checkmark box or some way to indicate what selection has been made? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngr

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

smithjd added a comment. This test fails: FAIL! : TagLibExtractorTest::testMp4(mp4) Compared values are not the same Actual (resultMp4.properties().value(Property::Rating).toInt()): 0 Expected (8) : 8 Loc: [/home/enderw

D19655: [kfilemetadata] Make it compile without foreach

mlaurent added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:928 > The changes in taglibextractor are no longer necessary after D18826 > has landed, you can omit these. Ah ? so all was not commited when you wrote that it"s ok to regen

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/72/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 17:17:55 + Build duration: 4 min 37 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 17:17:55 + Build duration: 2 min 12 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/80/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 17:17:55 + Build duration: 1 min 59 sec and counting JUnit Tests Name: p

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 53608. valeriymalov marked 3 inline comments as done. valeriymalov added a comment. - do not ignore results of PostingDB::iter in case of an error/end of db REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=522

D19633: Improve consistency of window-* and add more

This revision was automatically updated to reflect the committed changes. Closed by commit R266:3bc4079c220e: Improve consistency of window-* and add more (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53571&id=53607 REVISI

D19633: Improve consistency of window-* and add more

ndavis added a comment. window-shade can be added in a later patch so that this one isn't unnecessarily held back REPOSITORY R266 Breeze Icons BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg, ngraham Cc: ngraham, kde-fra

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 16:47:24 + Build duration: 22 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/51/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 16:47:24 + Build duration: 7 min 49 sec and counting BUILD ARTIFACTS abi-compatibility-

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7a79f1531480: [FileCopyJob] Clean up after cancelation of file copy operation (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=53605&id=5

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

chinmoyr updated this revision to Diff 53605. chinmoyr retitled this revision from "[FileCopyJob] Clean up after file copy operation is cancelled" to "[FileCopyJob] Clean up after cancelation of file copy operation". chinmoyr edited the summary of this revision. chinmoyr added a comment. Upda

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 53604. chinmoyr marked an inline comment as done. chinmoyr added a comment. Changed m_bFileWriteInProgress -> m_bFileCopyInProgress REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=53297&id=53604 BRANCH arcpatch-

D19557: Update css

ognarb updated this revision to Diff 53603. ognarb added a comment. Don't change image size REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53598&id=53603 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES com

D19633: Improve consistency of window-* and add more

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R266 Breeze Icons BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg, ngraham Cc: ngraham, kde-fram

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > Taglib does not "handle this nicely". For APE and Xiph, it just accepts *any* > unknown key and uses it verbatim, while for MP4 and ASF it rejects any > unknown key. > > The setProperties() is also quite in

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 15:03:05 + Build duration: 7 min 11 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/41/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 15:03:04 + Build duration: 2 min 20 sec and counting BUILD ARTIFACTS abi-comp

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

This revision was automatically updated to reflect the committed changes. Closed by commit R286:649555ee3182: Rewrite the taglib extractor to use the generic PropertyMap interface (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18826?vs=53587&id=53599#toc REPOSITO

D19655: [kfilemetadata] Make it compile without foreach

bruns added inline comments. INLINE COMMENTS > externalextractor.cpp:151 > +const auto lstKeys = propertiesObject.keys(); > +for (const auto &key : lstKeys) { > if (key == QStringLiteral("typeInfo")) { Can you change this to iterate over the entries, without intermediate list?

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thanks, looks good to me now. REPOSITORY R286 KFileMetaData BRANCH arcpatch-D18826 REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: smith

D19557: Update css

ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. Can you please not overwrite top-kde.jpg too, or at least use the same size? Because the change of size may be a problem for existing users (if any, but I consider those files

D19097: Add a test and document PropertyMap/VariantMap conversion

astippich abandoned this revision. astippich added a comment. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19097 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19098 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19557: Update css

yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-framework

D19557: Update css

ognarb updated this revision to Diff 53598. ognarb added a comment. - Add deleted image - Rename top-kde.png to kde.png - Fix strange margin issues for some elements @rooty The font can be changed in the khelpcenter settings. But it's strange that it doesn't use Plasma settings per de

D19646: Redesign KDE Connect and bluetooth config pages

ltoscano added a comment. Less technical note: I think that the commit message should not really about KDE Connect, as the change is reflected on all Purpose's users. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham

D19442: [Kfilemetada] Make it compile without foreach

mlaurent abandoned this revision. mlaurent added a comment. I recreated it in "https://phabricator.kde.org/D19655"; REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19442 To: mlaurent, dfaure, apol, bruns Cc: bruns, astippich, kde-frameworks-devel, #baloo, genna

D19655: [kfilemetadata] Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R286 KFi

D19557: Update css

yurchor added a comment. In D19557#428394 , @ltoscano wrote: > Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages the templates used to generate the PDFs. I have no objections. This part is not used for PDFs, bt

D19557: Update css

ltoscano added a subscriber: yurchor. ltoscano added a comment. On the graphical side I'm not the most qualified to talk :) Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages the templates used to generate the PDFs. From the technical point of view, I wouldn't

D19652: Add cross-compilation support for kpackagetool5

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19652 AFFECTED FILES CMakeLists.txt KF5Pac

D19557: Update css

rooty added a comment. Can you make it use Noto Sans by any chance? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update css

aacid added a subscriber: ltoscano. aacid added a comment. @ognarb i don't really have much to say here, my comment was just about a new file being introduced that seemed unnecessary. I'd say you want @ltoscano for someone that probably knows a bit about docs.kde.org code and maybe someo

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 53587. astippich marked an inline comment as done. astippich added a comment. - spelling fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=53585&id=53587 BRANCH arcpatch-D18826 REVISION DETAIL

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich marked 3 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:364 > This intermediate list is not required, you can directly call result->add() > for each attribute in lstASF. After further investigation there is no need to loo

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 53585. astippich added a comment. - update REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=52890&id=53585 BRANCH arcpatch-D18826 REVISION DETAIL https://phabricator.kde.org/D18826 AFFECTED FILES

D19511: ViewPrivate: Disable read-only mode action when doc is modified

loh.tar added a comment. So, then I assume you would be pro this patch. I notice one behavior that would be against this patch but not pro the meaning of "Read Only Mode". When you set this setting and issue a save request you get the "Save as" dialog. Such behavior is good in any case.

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 09:40:06 + Build duration: 8 min 24 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 09:40:05 + Build duration: 5 min 29 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 09:35:31 + Build duration: 9 min 0 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 09:35:31 + Build duration: 8 min 19 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 09:38:45 + Build duration: 3 min 47 sec and counting JUnit Tests Name

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 09:35:30 + Build duration: 3 min 22 sec and counting JUnit Tests Name: pr

D19461: Logcat: fix dsError color with underline="0"

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1296052d48b3: Logcat: fix dsError color with underline="0" (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19461?vs=53426&id=53579

D19461: Logcat: fix dsError color with underline="0"

nibags added a comment. Yes, this corresponds to the bug you mention. In the "Vim (dark)" scheme, bold="0" doesn't work either, since all the text is bold. REPOSITORY R216 Syntax Highlighting BRANCH logcat-fix-error-color REVISION DETAIL https://phabricator.kde.org/D19461 To: nibag