astippich marked 3 inline comments as done. astippich added inline comments.
INLINE COMMENTS > bruns wrote in taglibextractor.cpp:364 > This intermediate list is not required, you can directly call result->add() > for each attribute in lstASF. After further investigation there is no need to look for more than one entry, since there cannot be duplicated keys. This is also what TagLib does internally. So I changed it to be more inline with the generic extraction. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams