D8958: Fix unintentional breadcrumb menu item activation

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, OK. REPOSITORY R241 KIO BRANCH fix_accidental_breadcrumb_menu_item_activation REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks, dfaure Cc: brouli

D10646: Support case-insensitive WordDetect

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. In general looks good, and it even revealed a bug as I understand. However, the KTextEditor framework still has its own implementation of the syntax highlighting. Can you also provi

D10627: Reduce plasmashell frozen time to almost nothing

jtamate retitled this revision from "Reduce plasma lock up time to almost nothing" to "Reduce plasmashell frozen time to almost nothing". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R120 Plasma Workspace BRANCH polling (branched fro

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 197 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/197/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 19 Feb 2018 04:00:34 + Build duration: 1 hr 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/121/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Feb 2018 04:00:34 + Build duration: 31 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 141 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/141/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Feb 2018 04:00:34 + Build duration: 25 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/139/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 19 Feb 2018 04:00:34 + Build duration: 10 min and counting JUnit Tests Name: (root) Faile

D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a comment. In D8958#209050 , @dfaure wrote: > Instead of the bool member, isn't it enough to test the distance again in mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one difference of behaviour in cas

D10279: add 24px media-album-cover icon

ngraham added a comment. You're not doing anything wrong, we're just being a bit slow to respond, and I'm sorry for that. I'll see if I can rustle up some reviewers. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10279 To: astippich, #breeze, #vdg, andreaska C

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. Fixing now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ltoscano added a comment. In D10635#209216 , @ngraham wrote: > I like to use the full string since not all of our users or people browsing the bug tracker will be familiar enough with all our products and their versioning conventions to able to

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. I like to use the full string since not all of our users or people browsing the bug tracker will be familiar enough with all our products and their versioning conventions to able to map a version number to its product. Is there a technical reason why the field should

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ltoscano added a comment. FIXED-IN: 5.44 is enough. Not sure why the rules about the versioning changed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. Thanks for the patch! For formatting guidelines, please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch In essence, put "BUG: 383764" on its own line in the Summary section, and remove it from the title. Also please put "FIXED-

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 140 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/140/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 18 Feb 2018 21:56:18 + Build duration: 28 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 196 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/196/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 18 Feb 2018 21:56:18 + Build duration: 14 min and counting CONSOLE OUTPUT [.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 138 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/138/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 18 Feb 2018 21:56:18 + Build duration: 11 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/120/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 18 Feb 2018 21:56:18 + Build duration: 6 min 4 sec and counting JUnit Tests Name: (

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10616 To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg Cc: markg, michaelh

D10646: Support case-insensitive WordDetect

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH word_insensitive REVISION DETAIL

D10433: Add QML support for Prison

svuorela added a comment. I am a bit unsure if this is the right approach. I can still be convinced both ways. one of the big differences from prison/qt4 to prison/qt5 was that it changed from being a barcode display library to a barcode generation library, removing all means of actuall

D8958: Fix unintentional breadcrumb menu item activation

dfaure added a comment. Instead of the bool member, isn't it enough to test the distance again in mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one difference of behaviour in case someone moves the mouse a bit and then back to the original position, in that case the

D10450: Generate a custom target in kcoreaddons_desktop_to_json

tcberner abandoned this revision. tcberner added a comment. Works for me REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

rakuco added a comment. I agree this can be abandoned -- whatever solution we agree upon should probably be done in plasma-desktop. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco Cc: bcooksley, rikmills

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

chinmoyr added a dependent revision: D10568: Handle privilege operation confirmation prompts in SlaveBase. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10567 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr edited the summary of this revision. chinmoyr added a dependency: D10567: Remove handling of privilege operation confirmation prompts from KIO::Job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10568 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10641: Revoke temporary authorization of KIO slave before sending it to klauncher

chinmoyr edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10437: Revoke authorization of file ioslave before it is used by another process

chinmoyr updated this revision to Diff 27483. chinmoyr retitled this revision from "Limit the use of file.so for privilege operation to one application" to "Revoke authorization of file ioslave before it is used by another process". chinmoyr edited the summary of this revision. chinmoyr edited th

D10437: Limit the use of file.so for privilege operation to one application

chinmoyr updated this revision to Diff 27482. chinmoyr added a comment. Changed approach. Now temporary authorization is revoked. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10437?vs=26905&id=27482 BRANCH master REVISION DETAIL https://phabricator.kde.

D10641: Revoke temporary authorization of KIO slave before sending it to klauncher

chinmoyr added a dependent revision: D10437: Revoke authorization of file ioslave before it is used by another process. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of KIO slave before sending it to klauncher. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10638 To: chinmoyr, #frameworks Cc: michaelh

D10641: Revoke temporary authorization of KIO slave before sending it to klauncher

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY An idle slave authorized for privilege operation can be easil

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of KIO slave before sending it to klauncher. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10568 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10627: Reduce plasma lock up time to almost nothing

broulik added a comment. It's lookup, not lockup REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai,

D10629: Avoid a double emitResult()

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. A quick search through plasma codebase reveals that `setResult` followed by `emitResult` is done quite often. Care to fix these, too? :) REPOSITORY R120 Plasma Workspace BRANCH doubl

D10433: Add QML support for Prison

vkrause added a comment. ping? :) REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

chinmoyr updated this revision to Diff 27478. chinmoyr added a comment. removed m_data REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10567?vs=27315&id=27478 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10567 AFFECTED FILES src/core/job.c

D10636: Add support for revoking temporary authorization in KAuth

chinmoyr added a dependent revision: D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10636 To: chinmoyr, #frameworks Cc: fvogt, dfaure, michaelh

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Same as title. Depends on D10636 REPOSITORY R283 KAuth BRANCH ma

D10636: Add support for revoking temporary authorization in KAuth

chinmoyr edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10636 To: chinmoyr, #frameworks Cc: fvogt, dfaure, michaelh

D10636: Add support for revoking temporary authorization in KAuth

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Revoking authorization for a KAuth::Action is required to fix one security issue in KIO's file ioslave. TEST P

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

meven created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. meven requested review of this revision. REVISION SUMMARY Add a DeleteJob for the last file that was being copied/moved when pasting or dropping a file when th

D10625: Fix readelf command name on x86

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ca65aab3a12b: Fix readelf command name on x86 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10625?vs=27448&id=27471 REVISION DE

D10602: Remove obsolete policy settings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e0f78079800c: Remove obsolete policy settings (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10602?vs=27399&id=27470 REVISION DE

D10601: Extend search path for NDK dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R240:37c2eba28855: Extend search path for NDK dependencies (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10601?vs=27398&id=27469 REV

Re: proposal to extend and to improve KColorSchemeManager

On Sun, Feb 18, 2018 at 2:56 PM, Alexander Semke wrote: > Hi, > > I recently switched from using Digikam's code for the handling of color > schemes in the application to KColorSchemeManager in LabPlot [1]. > It works, but there're couple of things that I miss: > > * "Default"-entry in the color sc

D10601: Extend search path for NDK dependencies

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10601 To: vkrause, #build_system, apol Cc: #frameworks, michaelh

D10602: Remove obsolete policy settings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10602 To: vkrause, #build_system, apol Cc: #frameworks, michaelh

D10625: Fix readelf command name on x86

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10625 To: vkrause, #build_system, apol Cc: #frameworks, michaelh

proposal to extend and to improve KColorSchemeManager

Hi, I recently switched from using Digikam's code for the handling of color schemes in the application to KColorSchemeManager in LabPlot [1]. It works, but there're couple of things that I miss: * "Default"-entry in the color scheme menu to easily switch to the default desktop color scheme *

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. In D10414#208515 , @bcooksley wrote: > Looks like QT_LSTAT doesn't exist on Windows - see https://git.reviewboard.kde.org/r/127727/ Would including "kioglobal_p.h" perhaps fix this? #ifndef QT_LSTAT #def

D10617: Fix "ambiguous shortcut" issue introduced with D10314

markg added a comment. In D10617#208703 , @elvisangelaccio wrote: > In D10617#208513 , @ngraham wrote: > > > The shortcut won't affect other apps since the file dialog its its own context. Even if

D10631: Update links to dependencies, and mark Android as officially supported

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10631 To: vkrause, svuorela Cc: #frameworks, michaelh

D10603: Make DMTX dependency optional

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10603 To: vkrause, #frameworks, svuorela Cc: michaelh

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in fileundomanager.cpp:404 > Yep. Ok, that's enough to fix the dolphin side, but now the new unit test doesn't pass... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure

D10631: Update links to dependencies, and mark Android as officially supported

vkrause created this revision. vkrause added a reviewer: svuorela. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.

D10603: Make DMTX dependency optional

vkrause updated this revision to Diff 27458. vkrause added a comment. Address review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10603?vs=27400&id=27458 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10603 AFFECTED FILES CMa

D10617: Fix "ambiguous shortcut" issue introduced with D10314

elvisangelaccio added a comment. In D10617#208513 , @ngraham wrote: > The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there'

D10629: Avoid a double emitResult()

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY ServiceJob::setResult already does a emitResult. Disc

D10627: Reduce plasma lock up time to almost nothing

jtamate added a comment. May I do the other 2 commits without another revision? REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: davidedmundson, plasma-devel,

D10627: Reduce plasma lock up time to almost nothing

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. This code already has a platform check before adding the native event filter. IMHO we could just make this an assert. But I like your approach too. REPOSITORY R12

D10627: Reduce plasma lock up time to almost nothing

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY CCBUG: 358231 CCBUG: 342056 Even the icon with the

D10279: add 24px media-album-cover icon

astippich added a comment. Hi, it would be nice to get some feedback on this. Same for D10293 and D10292 . If this is not the proper way to contribute to breeze icons, please point me in the right direction. REPOSITO

D10603: Make DMTX dependency optional

svuorela added a comment. Thanks. The ability to cleanly do something like that was one of the reasons for the api changes I did between qt4 and qt5. INLINE COMMENTS > prison.cpp:44 > +#ifdef HAVE_DMTX > case Prison::DataMatrix: > return new DataMatrixBarcode; I'm wond

D10625: Fix readelf command name on x86

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY The prefix for the command is i686-linux-andr

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

jtamate added a comment. #10 0x7ff925c93845 in KJob::finishJob(bool) (this=0x221d0d0, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:101 #11 0x7ff925c93f9b in KJob::emitResult() (this=0x221d0d0) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

jtamate updated this revision to Diff 27444. jtamate added a comment. Now with an Q_ASSERT that really shows the origin of the problem. In the case of pressing the "skip All" button when can't change permissions is: REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabr