dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land.
In general looks good, and it even revealed a bug as I understand. However, the KTextEditor framework still has its own implementation of the syntax highlighting. Can you also provide a patch there, so both implementations behave the same? INLINE COMMENTS > rule_p.h:249 > QString m_word; > + Qt::CaseSensitivity m_caseSensitivity; > }; Could you initialize this to CaseInsensitive with in-class member initialization? REPOSITORY R216 Syntax Highlighting BRANCH word_insensitive REVISION DETAIL https://phabricator.kde.org/D10646 To: jpoelen, dhaumann Cc: dhaumann, #frameworks, michaelh
