svuorela added a comment.
I am a bit unsure if this is the right approach. I can still be convinced both ways. one of the big differences from prison/qt4 to prison/qt5 was that it changed from being a barcode display library to a barcode generation library, removing all means of actually displaying them. I don't know if a better approach would be to still not actually display anything, but do a bit more to make it possible to just use a AbstractBarcode in a QImageItem. I am also not sure how a custom AbstractBarcode could be fitted in here, and if it is actually relevant to care for a thirdparty AbstractBarcode implementation. This is a bit of rambling, but I'm not fully sure what way to sway. The code as such is good, but I'd like to just bounce these questions around first. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh
