Re: Review Request 128672: some fixes for javascript Math object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128672/ --- (Updated Dec. 19, 2016, 3:32 a.m.) Review request for KDE Frameworks, Ber

Re: Review Request 129654: Introduce the resource name in the knsrc file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/ --- (Updated Dec. 19, 2016, 3:08 a.m.) Status -- This change has been ma

Re: Review Request 129654: Introduce the resource name in the knsrc file

> On Dec. 16, 2016, 5:55 p.m., Aleix Pol Gonzalez wrote: > > Waiting for feedback from tsdgeos on the change in scripty. > > Albert Astals Cid wrote: > Looks good (make sure you commit to the correct location (i.e. i guess we > want this for stable and trunk kf5, not kdelibs 4 version of th

[Differential] [Updated] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

kossebau added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:163 > Maybe call it `ECM_ALTERNATIVE_ROOT_PATH`, in case we ever need to use it on > other platforms as well? Hm, indeed a point in that ECM_ANDROID_ROOT_PATH sounds like this is the only one and might replace the ro

Re: Review Request 129654: Introduce the resource name in the knsrc file

> On Dec. 16, 2016, 4:55 p.m., Aleix Pol Gonzalez wrote: > > Waiting for feedback from tsdgeos on the change in scripty. Looks good (make sure you commit to the correct location (i.e. i guess we want this for stable and trunk kf5, not kdelibs 4 version of the scripts)) - Albert

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/ --- (Updated Дек. 18, 2016, 9:55 след обяд) Review request for KDE Frameworks

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Дек. 10, 2016, 6:36 преди обяд, Anthony Fieroni wrote: > > filenamesearch/kio_filenamesearch.cpp, line 113 > > > > > > Or we must keep KIO::UDSEntry::UDS_URL in new patch ? David, any suggestion? Am i on ri

[Differential] [Commented On] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

apol added inline comments. INLINE COMMENTS > Android.cmake:163 > > +SET(CMAKE_FIND_ROOT_PATH ${ANDROID_NDK} ${ECM_ANDROID_ROOT_PATH}) > +SET(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER) Maybe call it `ECM_ALTERNATIVE_ROOT_PATH`, in case we ever need to use it on other platforms as well? > Andro

[Differential] [Accepted] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

cordlandwehr accepted this revision. cordlandwehr added a comment. The patch absolutely goes into the right direction. All changes look fine to me. However, I did not test the patch yet, since I am currently in the process of updating my cross-compilation setup. IMO it is also fine to not p

[Differential] [Commented On] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

kossebau added a comment. Ping?`@apol, @cordlandwehr, any comment on this? And does this improve or at least not regress with how GCompris & KStars Light developers build for Android? I would like to avoid having to fork the toolchain file for Marble :/ REPOSITORY R240 Extra CMake Mo

Re: Review Request 129663: Don't break accelerators in KToolBar

> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Дек. 18, 2016, 10:51 преди обяд, Martin Gräßlin wrote: > > src/kstatusnotifieritem.cpp, line 980 > > > > > > AFAIK show and showNormal is the same. What is the difference here? > > Anthony Fieroni wrote: >

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Dec. 18, 2016, 9:51 a.m., Martin Gräßlin wrote: > > src/kstatusnotifieritem.cpp, line 980 > > > > > > AFAIK show and showNormal is the same. What is the difference here? > > Anthony Fieroni wrote: > The

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Дек. 18, 2016, 10:51 преди обяд, Martin Gräßlin wrote: > > src/kstatusnotifieritem.cpp, line 464 > > > > > > please don't mix coding style changes with other changes. I will commit it separately > On Дек.

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review101490 --- src/kstatusnotifieritem.cpp (line 464)

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129666/ --- (Updated Дек. 18, 2016, 10:34 преди обяд) Review request for KDE Framewor

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

> On Дек. 17, 2016, 5:53 след обяд, Martin Klapetek wrote: > > Just because it "looks annoying" doesn't mean it doesn't have its use. > > > > I'll do the git-blame-search for you: > > https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f > > Anthony Fiero