> On Дек. 17, 2016, 5:53 след обяд, Martin Klapetek wrote: > > Just because it "looks annoying" doesn't mean it doesn't have its use. > > > > I'll do the git-blame-search for you: > > https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f > > Anthony Fieroni wrote: > I will correct GwenView too, about me this patch is at wrong place > > Martin Klapetek wrote: > This is not about Gwenview, this is about safe API that won't break with > any other app actually not providing the reason. > > Please leave this part alone.
It's same safe api, it will be safe. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129666/#review101483 ----------------------------------------------------------- On Дек. 17, 2016, 5:48 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129666/ > ----------------------------------------------------------- > > (Updated Дек. 17, 2016, 5:48 след обяд) > > > Review request for KDE Frameworks and Martin Klapetek. > > > Repository: knotifications > > > Description > ------- > > "no_reason_specified" looks annoying reason > > > Diffs > ----- > > src/knotificationrestrictions.h e9179ae > src/knotificationrestrictions.cpp 5f5d908 > > Diff: https://git.reviewboard.kde.org/r/129666/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
