apol added inline comments.
INLINE COMMENTS
> Android.cmake:163
>
> +SET(CMAKE_FIND_ROOT_PATH ${ANDROID_NDK} ${ECM_ANDROID_ROOT_PATH})
> +SET(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)
Maybe call it `ECM_ALTERNATIVE_ROOT_PATH`, in case we ever need to use it on
other platforms as well?
> Android.cmake:188
> set(CMAKE_FIND_LIBRARY_PREFIXES "lib")
> +# TODO: document why this check is needed
> find_library(GNUSTL_SHARED gnustl_shared)
This is unrelated. Also maybe while at it you can document it right away.
I just added it so that we can detect problems at config time rather than while
linking.
> Android.cmake:209
> +# needed for Qt to define Q_OS_ANDROID
> +add_definitions(-DANDROID)
> +
That's not requried, as the NDK already passes the `__ANDROID__`.
REPOSITORY
R240 Extra CMake Modules
BRANCH
avoidHostLibsIncludesinAndroidToolchain
REVISION DETAIL
https://phabricator.kde.org/D3646
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #frameworks, #gcompris, #minuet, apol, mutlaqja, sandsmark,
nienhueser, cordlandwehr
