Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-13 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/ --- Review request for KDE Frameworks and David Faure. Repository: kio-extras

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

2016-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/#review100824 --- I'm not sure that it makes sense, or maybe it just reads wei

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

2016-11-13 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129390/#review100816 --- src/krecentfilesaction.cpp (line 99)

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

2016-11-13 Thread Elvis Angelaccio
> On Nov. 13, 2016, 12:22 p.m., Anthony Fieroni wrote: > > src/krecentfilesaction.cpp, line 191 > > > > > > removeAction(selectableActionGroup()->actions().first())->deleteLater() > > > > This should wor

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

2016-11-13 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129390/#review100814 --- src/krecentfilesaction.cpp (line 185)

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

2016-11-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129390/ --- (Updated Nov. 13, 2016, 11:45 a.m.) Status -- This change has been d

Review Request 129390: KRecentFilesAction: remove unnecessary copy

2016-11-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129390/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Review Request 129389: KRecentFilesAction: improve addUrl() apidox

2016-11-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti