----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129390/#review100816 -----------------------------------------------------------
src/krecentfilesaction.cpp (line 99) <https://git.reviewboard.kde.org/r/129390/#comment67658> Yeah, you can't avoid copying, you can move it here QUrl url = m_urls[action]; emit q->urlSelection(url); But comment is needed again, because *strong* reference became weak - Anthony Fieroni On Ноев. 13, 2016, 1:45 след обяд, Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129390/ > ----------------------------------------------------------- > > (Updated Ноев. 13, 2016, 1:45 след обяд) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > ------- > > QUrl is implicitly shared, so the code does not do what the comment says. > Add also a test case to make sure that the crash described in the comment > doesn't happen anymore (again, thanks to implicit sharing). > > > Diffs > ----- > > autotests/krecentfilesactiontest.h f09bf6349e5b98999373d762fdbc4fd3a1f8e8f4 > autotests/krecentfilesactiontest.cpp > 1ba100dd1a8b5295e28c436157283e4f493563cd > src/krecentfilesaction.cpp 7ffe2e7b75e028346af3215dada8e96ea940d65b > > Diff: https://git.reviewboard.kde.org/r/129390/diff/ > > > Testing > ------- > > All tests pass. > > > Thanks, > > Elvis Angelaccio > >
