> On Nov. 13, 2016, 12:22 p.m., Anthony Fieroni wrote: > > src/krecentfilesaction.cpp, line 191 > > <https://git.reviewboard.kde.org/r/129390/diff/1/?file=485242#file485242line191> > > > > removeAction(selectableActionGroup()->actions().first())->deleteLater() > > > > This should work as expected, about me.
Doesn't make a difference. The crash happens when copying the QUrl, the QAction pointer is unrelated. - Elvis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129390/#review100814 ----------------------------------------------------------- On Nov. 13, 2016, 11:45 a.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129390/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2016, 11:45 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > ------- > > QUrl is implicitly shared, so the code does not do what the comment says. > Add also a test case to make sure that the crash described in the comment > doesn't happen anymore (again, thanks to implicit sharing). > > > Diffs > ----- > > autotests/krecentfilesactiontest.h f09bf6349e5b98999373d762fdbc4fd3a1f8e8f4 > autotests/krecentfilesactiontest.cpp > 1ba100dd1a8b5295e28c436157283e4f493563cd > src/krecentfilesaction.cpp 7ffe2e7b75e028346af3215dada8e96ea940d65b > > Diff: https://git.reviewboard.kde.org/r/129390/diff/ > > > Testing > ------- > > All tests pass. > > > Thanks, > > Elvis Angelaccio > >
