Re: Review Request 126403: Get rid of QApplication dependency

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90863 --- OK, I was mentionning the commit log because the one in review

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 10, 2016, 9:58 p.m.) Review request for KDE Frameworks, kwi

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-10 Thread Thomas Lübking
> On Jan. 10, 2016, 9:55 a.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 61 > > > > > > How does this work? I see code iterating through that list, but I don't > > see code adding to the li

Re: QSP patch/activator

2016-01-10 Thread René J . V . Bertin
On Sunday January 10 2016 18:43:25 David Faure wrote: > Otherwise where do you draw the line? You say "One or two", does that mean > that when you get to three frameworks > you suddenly switch to case 2? Of course not ;) Indeed, but see below. > In the qt5/kf5 world, there is only ONE kind of a

Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126712/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

2016-01-10 Thread Christoph Cullmann
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/#review90842 --- src/ioslaves/http/kcookiejar/kcookiejar.json (line 96)

Re: Jenkins scripts broken?

2016-01-10 Thread Ben Cooksley
On Mon, Jan 11, 2016 at 6:09 AM, David Faure wrote: > On Sunday 10 January 2016 14:32:01 no-re...@kde.org wrote: >> >> GENERAL INFO >> >> BUILD FAILURE >> Build URL: >> https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ >> Project: PLATFORM=Linux,compiler=gcc >> Dat

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/ --- (Updated Jan. 10, 2016, 6:05 p.m.) Review request for KDE Frameworks. C

Re: QSP patch/activator

2016-01-10 Thread David Faure
On Sunday 10 January 2016 17:04:14 René J.V. Bertin wrote: > On Saturday December 12 2015 19:32:34 David Faure wrote: > > I didn't mean switching at runtime. I mean using KF5 in Qt apps. > > I'm pretty sure we had this discussion already but here we go again: > > If a pure Qt app (say Scribus) has

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 234 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/234/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 10 Jan 2016 17:19:35 + Build duration: 6 min 23 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 234 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/234/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 10 Jan 2016 17:19:35 + Build duration: 2 min 50 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 227 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/227/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 10 Jan 2016 17:19:35 + Build duration: 3 min 18 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 227 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/227/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 10 Jan 2016 17:19:35 + Build duration: 5 min 37 sec CHANGE SET Revision 8

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 202 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/202/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 16:24:15 + Build duration: 12 min CHANGE SET Revision 158f62a6710a8ec02eeb9c4e94ee1badd591ae47 by Davi

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 194 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/194/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 16:24:15 + Build duration: 5 min 11 sec CHANGE SET Revision 158f62a6710a8ec02eeb9c4e94ee1badd59

Jenkins scripts broken?

2016-01-10 Thread David Faure
On Sunday 10 January 2016 14:32:01 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD FAILURE > Build URL: > https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Sun, 10 Jan 2016 14:02:42 + > Build duration:

Re: Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/ --- (Updated Jan. 10, 2016, 4:23 p.m.) Status -- This change has been ma

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

2016-01-10 Thread René J . V . Bertin
On Saturday December 12 2015 19:32:34 David Faure wrote: Somehow I never got around to answering this. Also directing this back to the lists. > I didn't mean switching at runtime. I mean using KF5 in Qt apps. > I'm pretty sure we had this discussion already but here we go again: > If a pure Qt

Jenkins-kde-ci: kded master kf5-qt5 » Linux,gcc - Build # 40 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:02:42 + Build duration: 1 min 11 sec CHANGE SET Revision 9bbb9f948fd0729e86e67793adf9d72598e0cc02 b

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 38 - Failure!

2016-01-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:02:42 + Build duration: 1 min 16 sec CHANGE SET Revision 9bbb9f948fd0729e86e67793adf9d72598e

Re: Review Request 126684: fix loading of RLE compressed PSD files

2016-01-10 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126684/ --- (Updated Jan. 10, 2016, 12:28 p.m.) Status -- This change has been m

Re: Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

2016-01-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/#review90838 --- Ship it! Ship It! - Kevin Funk On Jan. 10, 2016, 11:03 a.m

Review Request 126696: kssld: install DBus service file for org.kde.kssld5

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 126694: KHTML java applet viewer: repair broken DBus call to kpasswdserver

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126694/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/ --- (Updated Jan. 10, 2016, 10:28 a.m.) Review request for KDE Frameworks.

Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 126674: Add a thumbnailer for kra/ora images

2016-01-10 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126674/ --- (Updated Jan. 10, 2016, 10:01 a.m.) Status -- This change has been m

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-10 Thread David Faure
> On Jan. 9, 2016, 1:28 p.m., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? > > Luigi Toscano wrote: > I think it was already done: > https://mail.kde.org/pipermail/release-team/2016-January/009263.html > > Kai Uwe Broulik wrote: > ok, I was just wondering becau

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-10 Thread David Faure
> On Jan. 9, 2016, 1:28 p.m., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? > > Luigi Toscano wrote: > I think it was already done: > https://mail.kde.org/pipermail/release-team/2016-January/009263.html > > Kai Uwe Broulik wrote: > ok, I was just wondering becau

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90834 --- src/platforms/xcb/kwindowsystem.cpp (line 60)

Re: Review Request 126674: Add a thumbnailer for kra/ora images

2016-01-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126674/#review90833 --- Ship it! Code looks good, only found some coding style issues

Re: Review Request 126684: fix loading of RLE compressed PSD files

2016-01-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126684/#review90831 --- Ship it! Ship It! - Alex Merry On Jan. 9, 2016, 9:58 a.m.,