----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90863 -----------------------------------------------------------
OK, I was mentionning the commit log because the one in reviewboard says "still UNTESTED" ;) Anyhow, looks good to me now, but I'd rather that it gets reviewed by e.g. Martin Graesslin too. src/platforms/xcb/kwindowsystem.cpp (line 79) <https://git.reviewboard.kde.org/r/126403/#comment62080> this ';' seems unnecessary and weird, it's the end of an if() block. - David Faure On Jan. 10, 2016, 9:58 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126403/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2016, 9:58 p.m.) > > > Review request for KDE Frameworks, kwin and Albert Astals Cid. > > > Bugs: 354811 > https://bugs.kde.org/show_bug.cgi?id=354811 > > > Repository: kwindowsystem > > > Description > ------- > > summarized, alternative to https://git.reviewboard.kde.org/r/126397/ > > NOTICE: this compiles but is otherwise *completely* untested! > > > Diffs > ----- > > src/platforms/xcb/kwindowsystem.cpp 9d28704 > > Diff: https://git.reviewboard.kde.org/r/126403/diff/ > > > Testing > ------- > > Albert performed a successful test on the bug. > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
