Re: Review Request 122764: Adding missing licenses

2015-03-02 Thread Maximiliano Curia
> On March 3, 2015, 2:21 a.m., Michael Pyne wrote: > > OK, sounds good. Thanks, I don't have commit access. Can you push this change? Thanks again. - Maximiliano --- This is an automatically generated e-mail. To reply, visit: https://gi

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Marko Käning
Hi Michael, On 03 Mar 2015, at 03:30 , Michael Pyne wrote: > On Mon, March 2, 2015 20:15:20 Marko Käning wrote: >> So, having those ktp-* entries in dependency-data-stable-kf5-qt5 shouldn’t >> do any harm. >> >> But I don’t know how kdesrc-build will handle this, though... > > For missing en

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Michael Pyne
On Mon, March 2, 2015 21:22:32 Albert Astals Cid wrote: > El Dilluns, 2 de març de 2015, a les 20:49:45, Martin Klapetek va escriure: > > Makes me think that maybe the review process does not work that well... > > Correct, the review process doesn't work well at all, and hasn't been for a > long t

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Michael Pyne
On Mon, March 2, 2015 20:15:20 Marko Käning wrote: > So, having those ktp-* entries in dependency-data-stable-kf5-qt5 shouldn’t > do any harm. > >But I don’t know how kdesrc-build will handle this, though... For missing entries kdesrc-build will infer "master" as the git branch to use. It wo

Re: Review Request 122764: Adding missing licenses

2015-03-02 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122764/#review76935 --- Ship it! OK, sounds good. - Michael Pyne On Feb. 28, 2015,

Re: Review Request 122733: Fix path traversal checks in KPackage

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review76933 --- Ship it! Very nice. :) - Sebastian Kügler On Feb. 26, 2015

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Aleix Pol Gonzalez
> On March 2, 2015, 10:30 p.m., Kai Uwe Broulik wrote: > > That sounds like a bug in the qml engine to me: "The QML engine provides > > automatic type conversion between QVariantList and JavaScript arrays[…]" > > and I haven't seen any issues with the conversion. Did you try QStringList? I did

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/#review76927 --- That sounds like a bug in the qml engine to me: "The QML engin

Re: OSX/CI: purpose fails to build on branch master

2015-03-02 Thread Aleix Pol
On Mon, Mar 2, 2015 at 8:55 PM, Marko Käning wrote: > Hi Aleix, > > after adding a few dependencies: > --- > $ git diff > diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5 > index 7cf844f..2a303d4 100644 > --- a/dependency-data-kf5-qt5 > +++ b/dependency-data-kf5-qt5 > @@ -1002,6 +100

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Albert Astals Cid
El Dilluns, 2 de març de 2015, a les 20:49:45, Martin Klapetek va escriure: > On Mon, Mar 2, 2015 at 8:16 PM, Albert Astals Cid wrote: > > El Dilluns, 2 de març de 2015, a les 01:47:00, Martin Klapetek va escriure: > > > I would just like to point out that the review period of KPeople > > > is ov

OSX/CI: purpose fails to build on branch master

2015-03-02 Thread Marko Käning
Hi Aleix, after adding a few dependencies: --- $ git diff diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5 index 7cf844f..2a303d4 100644 --- a/dependency-data-kf5-qt5 +++ b/dependency-data-kf5-qt5 @@ -1002,6 +1002,12 @@ playground/base/kio-mtp: frameworks/ki18n playground/base/kio-m

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Martin Klapetek
On Mon, Mar 2, 2015 at 8:16 PM, Albert Astals Cid wrote: > El Dilluns, 2 de març de 2015, a les 01:47:00, Martin Klapetek va escriure: > > I would just like to point out that the review period of KPeople > > is over and all the associated moves are in order, are they not? > > What exactly is "eno

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Albert Astals Cid
El Dilluns, 2 de març de 2015, a les 01:47:00, Martin Klapetek va escriure: > I would just like to point out that the review period of KPeople > is over and all the associated moves are in order, are they not? > What exactly is "enormously rushed" when the review period > is over and moves are righ

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Marko Käning
Well, Luigi, this is what the logical deps say: --- "extragear/network/telepathy/*": { "stable-qt4": "kde-telepathy-0.9", "latest-qt4": "kde-telepathy-0.9" }, "kde/kdenetwork/ktp*": { "stable-qt4": "kde-telepathy-0.9", "latest-

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Albert Astals Cid
> On mar. 2, 2015, 8:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Marko Käning
Hi, On 02 Mar 2015, at 19:14 , Luigi Toscano wrote: > This should really be solved somehow in a more clear way, if I'm not > misunderstanding all the process: there is no stable version of ktp right now > for kf5. yes, I guess so. If there is no stable version for it, it shouldn’t appear in t

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Luigi Toscano
On Monday 02 of March 2015 19:08:57 Marko Käning wrote: > We need to remember that the stable-kf5-qt5 branch group needs to be kept in > sync whenever updating kf5-qt5… I committed the still missing info for it > in [1]. This should really be solved somehow in a more clear way, if I'm not misunde

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/#review76914 --- Ship it! Ship It! - Eike Hein On Feb. 27, 2015, 3:14 p.m.,

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- (Updated March 2, 2015, 6:14 p.m.) Status -- This change has been ma

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Marko Käning
We need to remember that the stable-kf5-qt5 branch group needs to be kept in sync whenever updating kf5-qt5… I committed the still missing info for it in [1]. Greets, Marko [1] http://commits.kde.org/kde-build-metadata/1aa3609df9b3b513c4fd555d38cb3d047f4e3c03 _

Review Request 122779: Make KFileItemDelegate handle non default devicePixelRatio in animations

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122779/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774/ --- (Updated March 2, 2015, 4:34 p.m.) Status -- This change has been ma

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/ --- (Updated March 2, 2015, 4:34 p.m.) Status -- This change has been ma

Re: Review Request 122776: Add test for qimageitem

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776/ --- (Updated March 2, 2015, 4:34 p.m.) Status -- This change has been ma

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76905 --- Ship it! Inviala! - Luca Beltrame On Mar. 2, 2015, 2:50 p.

Re: Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774/#review76906 --- Ship it! Oops, copy-paste error on my part... thanks for spot

Re: Review Request 122776: Add test for qimageitem

2015-03-02 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776/#review76904 --- +1 from me, given I touched this code recently. - Luca Beltra

Re: Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774/#review76895 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2015, 3

Re: Review Request 122776: Add test for qimageitem

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776/#review76892 --- Ship it! How hard would it be to get an autotest? :D - Aleix

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76893 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2015, 3

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/ --- (Updated March 2, 2015, 2:50 p.m.) Review request for KDE Frameworks. S

Review Request 122776: Add test for qimageitem

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Review Request 122775: Only nativeWidth/heights need updating.

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Martin Klapetek
On March 2, 2015, 5:21 a.m., Jerome Leclanche wrote: > > Should we be using ::tr here instead of not translating at all? > > Jerome Leclanche wrote: > Consensus on IRC six days ago was that dropping translation altogether > was fine. > I can add some ::tr but it's arguable whether some

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Hrvoje Senjan
> On March 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Albert Astals Cid
> On mar. 2, 2015, 8:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Aleix Pol
On Mon, Mar 2, 2015 at 9:15 AM, Marko Käning wrote: > Hi, > > I think CI still needs something like this: > --- > $ git diff > diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5 > index 3731ec6..6005971 100644 > --- a/dependency-data-kf5-qt5 > +++ b/dependency-data-kf5-qt5 > @@ -241,6

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Hrvoje Senjan
> On March 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review76873 --- +1 - David Edmundson On Feb. 25, 2015, 5:40 p.m., Marco Mar

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
> On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
> On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Jerome Leclanche
> On March 2, 2015, 8:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: >

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
> On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called _qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) Sorry, there is also anothe

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
> On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: > > Ship It! Please fix the extracted pot so that it is called _qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) - Luigi --- T

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
On Mar. 2, 2015, 5:21 a.m., Jerome Leclanche wrote: > > Should we be using ::tr here instead of not translating at all? > > Jerome Leclanche wrote: > Consensus on IRC six days ago was that dropping translation altogether > was fine. > I can add some ::tr but it's arguable whether some o

Re: KPeople part of KDE Frameworks

2015-03-02 Thread Marko Käning
Hi, I think CI still needs something like this: --- $ git diff diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5 index 3731ec6..6005971 100644 --- a/dependency-data-kf5-qt5 +++ b/dependency-data-kf5-qt5 @@ -241,6 +241,11 @@ frameworks/plasma-framework: frameworks/kwindowsystem framew

Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

2015-03-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122770/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review76863 --- Ship it! Ship It! - Martin Gräßlin On March 2, 2015, 9:02

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated March 2, 2015, 8:02 a.m.) Review request for KDE Frameworks, Mar