-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/
-----------------------------------------------------------
(Updated March 2, 2015, 8:02 a.m.)
Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
Changes
-------
Brought back Messages.sh
Repository: kglobalaccel
Description
-------
Remove the runtime's KAboutData
The about data was unexposed, but created a dependency on KCoreAddons (for
KAboutData) and in turn on KI18n for the translations of the aboutData.
This removes both dependencies as well as the string extraction scripts.
--
Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
like to, however it currently has too many dependencies. See
https://github.com/lxde/lxqt/issues/507 for related discussion.
I'm unsure myself if the about data is actually exposed somewhere I completely
missed, but it doesn't look that way.
Diffs (updated)
-----
CMakeLists.txt 68ad795
src/runtime/CMakeLists.txt e639fa5
src/runtime/globalshortcutsregistry.cpp 3e4d720
src/runtime/kglobalacceld.cpp 4e7cb9d
src/runtime/main.cpp fdf4d62
Diff: https://git.reviewboard.kde.org/r/122680/diff/
Testing
-------
Compiles and runs. No further testing done.
Thanks,
Jerome Leclanche
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
