Re: Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75661 --- Ship it! Nice! - David Faure On Feb. 9, 2015, 3:24 a.m., J

Re: Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- (Updated Feb. 8, 2015, 8:24 p.m.) Review request for KDE Frameworks, Davi

Review Request 122495: CMake nitpicking on KDiagram

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122495/ --- Review request for KDE Frameworks and Friedrich W. H. Kossebau. Repositor

Re: Review Request 122487: Reorder member variables to reduce memory usage.

> On Feb. 8, 2015, 9:45 p.m., David Faure wrote: > > Which magic tool did you come up with this time, to detect such things? :-) +1 :D I too want to know! - Aleix --- This is an automatically generated e-mail. To reply, visit: https://g

Re: strange problem with KConfig

On February 5, 2015 08:49:16 PM Marco Martin wrote: > Hi all, > I was investigating this bug.. > https://bugs.kde.org/show_bug.cgi?id43583 > > but after digging and digging, it looks like more and more an issue in > KConfig.. > basically if there is a config file in a system-wide location (to give

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75648 --- -1 You use C-Style casts. Oke, the frameworks coding style do

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75646 --- `qRound`? - Kevin Funk On Feb. 8, 2015, 11:12 p.m., Jeremy

Re: Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75645 --- Why not port to `http://doc.qt.io/qt-5/qprocessenvironment.ht

Review Request 122493: Use math.h round rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/ --- Review request for KDE Frameworks and Marco Martin. Repository: kdeclarat

Re: Review Request 122462: [KCompletion] Fix typos in documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/ --- (Updated feb. 8, 2015, 10:46 p.m.) Review request for KDE Frameworks. C

Re: Review Request 122462: [KCompletion] Fix typos in documentation

> On feb. 7, 2015, 7:14 p.m., Dominik Haumann wrote: > > Using two spaces is called "sentence spacing" and most probably done by > > intention, see http://en.wikipedia.org/wiki/Sentence_spacing > > So this is a matter of taste, and should not be changed especially in the > > licensing headers.

Re: Review Request 122481: Fix use of environ for OS X

> On Feb. 8, 2015, 5:44 p.m., René J.V. Bertin wrote: > > src/widgets/kurlcompletion.cpp, line 836 > > > > > > Qt5 has Q_OS_OSX to target OS X rather than a Mac OS (which according > > to Qt includes iOS). > >

Re: C++11 policy in frameworks?

> Qt supports 10.7 though so maybe we shouldn't be using these > newer c++11 methods in frameworks just yet right? As seen on the 'policies' page, we are not tied to all the platforms that are supported by Qt. This was decided in the thread named "Supported Compilers / C++11 Support in KF5", star

Re: Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- (Updated Feb. 8, 2015, 3:06 p.m.) Review request for KDE Frameworks, Davi

Re: C++11 policy in frameworks?

Yeah it's using the newest xcode for is x 10.7 so the libc++ is probably older, Qt supports 10.7 though so maybe we shouldn't be using these newer c++11 methods in frameworks just yet right? On Feb 8, 2015 2:04 PM, "Ivan Čukić" wrote: > > thought this was clang 3.7 maybe I'm confused though > > T

Review Request 122484: KCodecs: Fix i18n of character set names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122484/ --- Review request for KDE Frameworks. Repository: kcodecs Description

Re: C++11 policy in frameworks?

> thought this was clang 3.7 maybe I'm confused though This is (should not) be a problem with the compiler version - this is a library function. Which version of libc++ is it using? (it might be using the old system's one instead of the latest release or something) Cheerio, Ivan On 8 February 20

Re: C++11 policy in frameworks?

https://trac.macports.org/browser/trunk/dports/lang/llvm-3.7/Portfile I thought this was clang 3.7 maybe I'm confused though On Feb 8, 2015 1:39 PM, "Albert Astals Cid" wrote: > El Diumenge, 8 de febrer de 2015, a les 09:55:05, Jeremy Whiting va > escriure: > > Hey all, > > > > In trying to get k

Re: Review Request 122487: Reorder member variables to reduce memory usage.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487/#review75629 --- Ship it! Which magic tool did you come up with this time, to

Re: C++11 policy in frameworks?

El Diumenge, 8 de febrer de 2015, a les 09:55:05, Jeremy Whiting va escriure: > Hey all, > > In trying to get kf5 built on an older machine with clang 3.7 I've hit an > isuse with kdeclarative. clang 2.7 or 3.7? 3.7 is still unreleased, no? Cheers, Albert > A few days ago some code was chec

Review Request 122487: Reorder member variables to reduce memory usage.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: C++11 policy in frameworks?

That page was the result of the first discussion we had on C++11. More recently, there was a discussion on raising MSVC requirement. And, I'd say it was agreed to raise it to MSVC11 (VS12). At least, it was green-lighted by Kevin, Milian (I don't recall who else). I guess I should have updated th

Re: C++11 policy in frameworks?

On Sunday 08 February 2015 18:18:48 Aleix Pol wrote: > On Sun, Feb 8, 2015 at 5:55 PM, Jeremy Whiting wrote: > > Hey all, > > > > In trying to get kf5 built on an older machine with clang 3.7 I've hit an > > isuse with kdeclarative. A few days ago some code was checked into it that > > uses std::

Re: C++11 policy in frameworks?

On Sun, Feb 8, 2015 at 5:55 PM, Jeremy Whiting wrote: > Hey all, > > In trying to get kf5 built on an older machine with clang 3.7 I've hit an > isuse with kdeclarative. A few days ago some code was checked into it that > uses std::lround which isn't available on clang's stdlib implementation yet.

Re: Review Request 122482: Restore KCModule::setAuthAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122482/#review75617 --- src/kcmodule.cpp

C++11 policy in frameworks?

Hey all, In trying to get kf5 built on an older machine with clang 3.7 I've hit an isuse with kdeclarative. A few days ago some code was checked into it that uses std::lround which isn't available on clang's stdlib implementation yet. Should this change to floor or ciel, or is there an #ifdef we c

Re: Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75613 --- src/widgets/kurlcompletion.cpp

Review Request 122482: Restore KCModule::setAuthAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122482/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- Review request for KDE Software on Mac OS X, KDE Frameworks, David Faure, M

Re: Review Request 120442: Fix comments in Haskell highlighting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120442/ --- (Updated Feb. 8, 2015, 2:55 p.m.) Status -- This change has been mar

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/ --- (Updated Feb. 8, 2015, 2:42 p.m.) Status -- This change has been dis

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

> On Nov. 27, 2014, 7:29 a.m., Christoph Cullmann wrote: > > I actually would prefer no such hack in the public headers. > > If that is just to make porting easier, you can use that locally as a patch > > until the kdevplatform code is cleaned up. > > Milian Wolff wrote: > I still don't get

Jenkins build is back to stable : kross_master_qt5 #87

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122478: KConfigWidgets: Remove leftover uses of tr() for translation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122478/#review75600 --- Ship it! Ship It! - David Edmundson On Feb. 8, 2015, 1:11

Re: Review Request 122360: Make FTP error messages prettier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122360/ --- (Updated Feb. 8, 2015, 1:19 p.m.) Status -- This change has been mar

Review Request 122478: KConfigWidgets: Remove leftover uses of tr() for translation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122478/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/#review75596 --- Ship it! I don't know this code very well, but the reasoning

Re: kross: src/core/metafunction.h:89 char* to QByteArrayData*

On Wednesday 04 February 2015 19:54:36 Maximiliano Curia wrote: > Hi, > > As part of the packaging efforts in Debian we are testing the installed > headers to check that they compile correctly and have all their dependencies > installed. Nice :-) > Testing kross we found this: > // static metaob

Jenkins build became unstable: kross_master_qt5 #86

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/#review75594 --- src/core/kdesktopfile.cpp

Re: Review Request 122360: Make FTP error messages prettier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122360/#review75588 --- Ship it! Ship It! - David Faure On Feb. 1, 2015, 12:11 p.m

Re: Framework Categories

On Wednesday 04 February 2015 09:33:00 Jeremy Whiting wrote: > Ok, I've changed knewstuff to a "solution" type. Should all frameworks that > depend on kio be also changed to solution type ? Sounds right. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___