----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75613 -----------------------------------------------------------
src/widgets/kurlcompletion.cpp <https://git.reviewboard.kde.org/r/122481/#comment52289> Qt5 has Q_OS_OSX to target OS X rather than a Mac OS (which according to Qt includes iOS). For code that will never run on iOS it might be better to use Q_OS_OSX from the onset. - René J.V. Bertin On Feb. 8, 2015, 5:07 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122481/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2015, 5:07 p.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, David Faure, > Marko Käning, and René J.V. Bertin. > > > Repository: kio > > > Description > ------- > > On OS X 10.7 environ needs to be #defined as _NSGetEnviron() from > <crt_externs.h> according to man environ. This is also required for kio to > build on OS X 10.7 > > > Diffs > ----- > > src/widgets/kurlcompletion.cpp 1871c49a936e2ca322286e23ad6fe976ae2c7044 > > Diff: https://git.reviewboard.kde.org/r/122481/diff/ > > > Testing > ------- > > kio builds with this patch on OS X 10.7 and 10.10 > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
