> On Feb. 8, 2015, 5:44 p.m., René J.V. Bertin wrote: > > src/widgets/kurlcompletion.cpp, line 836 > > <https://git.reviewboard.kde.org/r/122481/diff/1/?file=347903#file347903line836> > > > > Qt5 has Q_OS_OSX to target OS X rather than a Mac OS (which according > > to Qt includes iOS). > > > > For code that will never run on iOS it might be better to use Q_OS_OSX > > from the onset.
I'd say Ship It, but that would be a little presumptuous for someone who's been shying away from so much as trying to build a single KF5 something :) - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75613 ----------------------------------------------------------- On Feb. 8, 2015, 11:06 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122481/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2015, 11:06 p.m.) > > > Review request for KDE Frameworks, David Faure, Marko Käning, and René J.V. > Bertin. > > > Repository: kio > > > Description > ------- > > On OS X 10.7 environ needs to be #defined as _NSGetEnviron() from > <crt_externs.h> according to man environ. This is also required for kio to > build on OS X 10.7 > > > Diffs > ----- > > src/widgets/kurlcompletion.cpp 1871c49a936e2ca322286e23ad6fe976ae2c7044 > > Diff: https://git.reviewboard.kde.org/r/122481/diff/ > > > Testing > ------- > > kio builds with this patch on OS X 10.7 and 10.10 > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
