Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/ --- (Updated Jan. 5, 2015, 1:20 a.m.) Status -- This change has been mar

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/#review73105 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 5, 2015, 12

Re: Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121836/ --- (Updated Jan. 5, 2015, 1 a.m.) Status -- This change has been marked

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/ --- (Updated Jan. 5, 2015, 12:59 a.m.) Review request for KDE Frameworks and

Re: Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121836/#review73098 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 4, 2015, 3:

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/#review73097 --- The file in the patch is marked as removed instead of renamed!

Re: Compile KF5 into Docker

2015-01-04 Thread Aleix Pol
On Sun, Jan 4, 2015 at 1:46 AM, Mathieu Tarral wrote: > Hi, > > as you know, building KF5 from source may not be an easy task, due to > build dependencies which may or may not be available for your distro. > > That's why I started to compile KF5 into a Docker container. > > This way you can keep y

[kapidox] src: Revert "Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org."

2015-01-04 Thread Ben Cooksley
Git commit 60ead7ae60b420f67ffed9c26d4646c343aa4601 by Ben Cooksley. Committed on 04/01/2015 at 21:10. Pushed by bcooksley into branch 'master'. Revert "Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org." This reverts commit 68

Re: Baloo Framework - License Exception

2015-01-04 Thread Albert Astals Cid
El Diumenge, 4 de gener de 2015, a les 11:23:49, David Faure va escriure: > On Tuesday 16 December 2014 14:02:18 Sebastian Kügler wrote: > > - If it's effectively GPL-licensed, it should not be a proper Framework > > I would like to challenge this reasoning. > > It seems to me that the premise is

Opinions on KIO Slave side sorting? Possible GSoC project?

2015-01-04 Thread Mark Gaiser
Hi, I was reading back an mailing list thread i started about half a year ago [1]. Later on in that thread Aaron suggested a cool idea of "slave side" sorting [2]. At that time i found it cool, but didn't really see a need for it. Dolphin is doing a fine job at sorting anyway, so why would we bot

Re: OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

2015-01-04 Thread Ivan Čukić
> Oxygen+Qt5 has inherited the "spaciousness" of breeze, which if you ask me it > does not make sense, i'd expect Oxygen+Qt5 and Oxygen+Qt4 to be the same +1 -- Cheerio, Ivan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Re: OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

2015-01-04 Thread Albert Astals Cid
Oxygen+Qt5 has inherited the "spaciousness" of breeze, which if you ask me it does not make sense, i'd expect Oxygen+Qt5 and Oxygen+Qt4 to be the same visually. Cheers, Albert El Diumenge, 4 de gener de 2015, a les 17:14:45, Andrius da Costa Ribas va escriure: > I refrain from calling win9x

Re: Review Request 121471: Port KDirSelectDialog to QFileDialog

2015-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121471/#review73086 --- Just like we have KFileWidget for an embeddable file-selection

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/#review73083 --- This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https:/

Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Change in kio[master]: KIO: new class KFileCopyToMenu. Adds Copy To / Move To to po...

2015-01-04 Thread David Faure (Code Review)
David Faure has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/305 Change subject: KIO: new class KFileCopyToMenu. Adds Copy To / Move To to popupmenus. .. KIO: new class KFileCopyToMenu. Adds Copy To /

Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121836/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121833/ --- (Updated Jan. 4, 2015, 3:37 p.m.) Status -- This change has been mar

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121833/#review73077 --- Ship it! Ship It! - Jeremy Whiting On Jan. 4, 2015, 8:19 a

Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121834/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Why so many QStyles

2015-01-04 Thread Hugo Pereira Da Costa
On 01/04/2015 02:54 PM, David Faure wrote: On Sunday 04 January 2015 13:51:15 David Faure wrote: 2) I can't think of a reason against passing qApp->style() to the KLineEditStyle ctor; the rest of the code in QProxyStyle::ensureBaseStyle is about the -style cmdline override (which qApp->style() h

Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121833/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 121828: Bring back "Please use http://bugs.kde.org to report bugs."

2015-01-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121828/ --- (Updated Jan. 4, 2015, 2:36 p.m.) Status -- This change has been mar

Re: Review Request 121828: Bring back "Please use http://bugs.kde.org to report bugs."

2015-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121828/#review73066 --- Ship it! Ah, this was in kcmdlineparser, I see. src/lib/kab

Review Request 121828: Bring back "Please use http://bugs.kde.org to report bugs."

2015-01-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121828/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Jenkins build is back to stable : kcoreaddons_stable_qt5 #27

2015-01-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kcoreaddons_master_qt5 #189

2015-01-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Why so many QStyles

2015-01-04 Thread David Faure
On Sunday 04 January 2015 13:51:15 David Faure wrote: > 2) I can't think of a reason against passing qApp->style() to the > KLineEditStyle ctor; the rest of the code in QProxyStyle::ensureBaseStyle is > about the -style cmdline override (which qApp->style() honours too). More testing gives a very

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2015-01-04 Thread David Faure
On Friday 19 December 2014 17:46:07 šumski wrote: > On Thursday 18 of December 2014 20:15:52 Martin Klapetek wrote: > > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > > Hi, > > > i've checked your clone, and what new requirements will that bring, and > > > if the > > > CMakeLists there are acc

Re: Compile KF5 into Docker

2015-01-04 Thread David Gil Oliva
Hi! El dia 04/01/2015 12:39, "Mathieu Tarral" va escriure: > > Hi, > > as you know, building KF5 from source may not be an easy task, due to > build dependencies which may or may not be available for your distro. > > That's why I started to compile KF5 into a Docker container. > > This way you ca

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/ --- (Updated Jan. 4, 2015, 12:54 p.m.) Status -- This change has been ma

Re: Why so many QStyles

2015-01-04 Thread David Faure
On Thursday 02 October 2014 22:10:05 Hugo Pereira Da Costa wrote: > In Qt5 this seems not to be true anymore and I've seen up to 6 QStyle > running concurently for a single Kate Window, increasing to 13 when > opening 'open file' dialog, decreasing back to 6 when closing it, etc. > Is this a know

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/#review73061 --- Ship it! Ship It! - David Faure On Jan. 4, 2015, 11:43 a.m

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/ --- (Updated gen. 4, 2015, 11:43 a.m.) Review request for KDE Frameworks. C

Compile KF5 into Docker

2015-01-04 Thread Mathieu Tarral
Hi, as you know, building KF5 from source may not be an easy task, due to build dependencies which may or may not be available for your distro. That's why I started to compile KF5 into a Docker container. This way you can keep your main system clean, and avoid to install a lot of *-dev packages.

Re: Replacement for KMimeType::isBinaryData?

2015-01-04 Thread David Faure
On Wednesday 29 October 2014 00:30:04 Kevin Funk wrote: > Heya, > > I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is > there some? > > http://lxr.kde.org/ident?v=kf5-qt5&_i=isBinaryData&_remember=1 shows exactly > two users of this function. > > Worth considering upstr

Re: [kapidox] src: Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org.

2015-01-04 Thread Ben Cooksley
On Sun, Jan 4, 2015 at 11:25 PM, David Faure wrote: > On Monday 29 December 2014 10:10:53 Ben Cooksley wrote: >> Git commit 6843f218411db3dba8d5fb53a578564dcb67d50e by Ben Cooksley. >> Committed on 29/12/2014 at 10:10. >> Pushed by bcooksley into branch 'master'. >> >> Workaround broken metadata i

Re: [kapidox] src: Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org.

2015-01-04 Thread David Faure
On Monday 29 December 2014 10:10:53 Ben Cooksley wrote: > Git commit 6843f218411db3dba8d5fb53a578564dcb67d50e by Ben Cooksley. > Committed on 29/12/2014 at 10:10. > Pushed by bcooksley into branch 'master'. > > Workaround broken metadata in the NetworkManager-Qt Framework which broke > all Framewo

Re: Baloo Framework - License Exception

2015-01-04 Thread David Faure
On Tuesday 16 December 2014 14:02:18 Sebastian Kügler wrote: > - If it's effectively GPL-licensed, it should not be a proper Framework I would like to challenge this reasoning. It seems to me that the premise is: * we need baloo * baloo currently needs Xapian * Xapian is GPL * the architecture we

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/#review73054 --- src/lib/kaboutdata.h

Jenkins build became unstable: kcoreaddons_master_qt5 #187

2015-01-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kcoreaddons_stable_qt5 #25

2015-01-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel